Re: [ARM EABI] Adjust 'libgomp.c++/target-cdtor-{1,2}.C' for 'targetm.cxx.use_aeabi_atexit' [PR119853, PR119854] (was: [Linaro-TCWG-CI] gcc-16-130-gaafe942227b: 10 regressions on arm)

Hi!

Maxim, thanks for the explanations.  Otherwise:

On 2025-07-21T15:12:59+1200, Maxim Kuvyrkov <[email protected]> wrote:
>> On Jul 18, 2025, at 23:51, Thomas Schwinge <[email protected]> wrote:
>> On 2025-04-26T00:09:21+0000, ci_notify--- via Gcc-regression <[email protected]> wrote:
>>> Our automatic CI has detected problems related to your patch(es). Please find some details below.
>>> 
>>> In gcc_check master-arm, after:
>>>  | commit gcc-16-130-gaafe942227b
>>>  | Author: Thomas Schwinge <[email protected]>
>>>  | Date:   Wed Apr 23 10:51:48 2025 +0200
>>>  | 
>>>  |     GCN, nvptx offloading: Host/device compatibility: Itanium C++ ABI, DSO Object Destruction API [PR119853, PR119854]
>>>  |     
>>>  |     '__dso_handle' for '__cxa_atexit', '__cxa_finalize'.  See
>>>  |     <https://itanium-cxx-abi.github.io/cxx-abi/abi.html#dso-dtor>.
>>>  |     
>>>  | ... 13 lines of the commit log omitted.
>>> 
>>> Produces 10 regressions:
>>>  | 
>>>  | regressions.sum:
>>>  | Running libgomp:libgomp.c++/c++.exp ...
>>>  | FAIL: libgomp.c++/target-cdtor-1.C scan-tree-dump-times optimized "gimple_call <__cxa_atexit, " 4
>>>  | FAIL: libgomp.c++/target-cdtor-1.C scan-tree-dump-times optimized "gimple_call <__cxa_atexit, NULL, _ZN1SD1Ev, \\&sH1, \\&__dso_handle>" 1
>>>  | FAIL: libgomp.c++/target-cdtor-1.C scan-tree-dump-times optimized "gimple_call <__cxa_atexit, NULL, _ZN1SD1Ev, \\&sH2, \\&__dso_handle>" 1
>>>  | FAIL: libgomp.c++/target-cdtor-1.C scan-tree-dump-times optimized "gimple_call <__cxa_atexit, NULL, _ZN1SD1Ev, \\&sHD1, \\&__dso_handle>" 1
>>>  | ... and 6 more
>>> 
>>> Used configuration :
>>> *CI config* tcwg_gcc_check master-arm
>>> *configure and test flags:* none, autodetected on armv8l-unknown-linux-gnueabihf
>>> 
>>> We track this bug report under https://linaro.atlassian.net/browse/GNU-1568.

>>> Please let us know if you have a fix.
>> 
>> I should have a fix: the attached
>> "Adjust 'libgomp.c++/target-cdtor-{1,2}.C' for 'targetm.cxx.use_aeabi_atexit' [PR119853, PR119854]"
>> ought to address this.  I've "mock-tested" this locally; is there a way
>> for me to run this through the Linaro "pre-commit" CI?
>
> Hi Christophe,
>
> Would you please give Thomas's patch a go?

Actually, no need: I've now found that on
<https://patchwork.sourceware.org/project/gcc/patch/[email protected]/>,
we (by now) have:

| Context	Check	Description
| [...]
| linaro-tcwg-bot/tcwg_gcc_check--master-arm	success	Test passed

..., and the linked
<https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/12469/artifact/artifacts/artifacts.precommit/notify/mail-body.txt> states:

| Produces  10 fixes:
|   | 
|   | fixes.sum:
|   | Running libgomp:libgomp.c++/c++.exp ...
|   | FAIL: libgomp.c++/target-cdtor-1.C scan-tree-dump-times optimized "gimple_call <__cxa_atexit, " 4
|   | FAIL: libgomp.c++/target-cdtor-1.C scan-tree-dump-times optimized "gimple_call <__cxa_atexit, NULL, _ZN1SD1Ev, \\&sHD1, \\&__dso_handle>" 1
|   | FAIL: libgomp.c++/target-cdtor-1.C scan-tree-dump-times optimized "gimple_call <__cxa_atexit, NULL, _ZN1SD1Ev, \\&sH2, \\&__dso_handle>" 1
|   | FAIL: libgomp.c++/target-cdtor-1.C scan-tree-dump-times optimized "gimple_call <__cxa_atexit, NULL, _ZN1SD1Ev, \\&sH1, \\&__dso_handle>" 1
|   | ... and 6 more

That's exactly what I needed to know.  Great service!  I've therefore
pushed to trunk branch commit 04b42c4245d85f77aa54ec002ebd7bbe6fde5f11
"Adjust 'libgomp.c++/target-cdtor-{1,2}.C' for 'targetm.cxx.use_aeabi_atexit' [PR119853, PR119854]".


Grüße
 Thomas


>>> If you have any questions regarding this report, please ask on [email protected] mailing list.
>>> 
>>> -----------------8<--------------------------8<--------------------------8<--------------------------
>>> 
>>> The information below contains the details of the failures, and the ways to reproduce a debug environment:
>>> 
>>> You can find the failure logs in *.log.1.xz files in
>>> * https://ci.linaro.org/job/tcwg_gcc_check--master-arm-build/3752/artifact/artifacts/00-sumfiles/
>>> The full lists of regressions and improvements as well as configure and make commands are in
>>> * https://ci.linaro.org/job/tcwg_gcc_check--master-arm-build/3752/artifact/artifacts/notify/
>>> The list of [ignored] baseline and flaky failures are in
>>> * https://ci.linaro.org/job/tcwg_gcc_check--master-arm-build/3752/artifact/artifacts/sumfiles/xfails.xfail
>>> 
>>> Current build   : https://ci.linaro.org/job/tcwg_gcc_check--master-arm-build/3752/artifact/artifacts
>>> Reference build : https://ci.linaro.org/job/tcwg_gcc_check--master-arm-build/3751/artifact/artifacts
>>> 
>>> Instruction to reproduce the build : https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/gcc/sha1/aafe942227baf8c2bcd4cac2cb150e49a4b895a9/tcwg_gcc_check/master-arm/reproduction_instructions.txt
>>> 
>>> Full commit : https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=aafe942227baf8c2bcd4cac2cb150e49a4b895a9
>> 
>> 
>> _______________________________________________
>> linaro-toolchain mailing list -- [email protected]
>> To unsubscribe send an email to [email protected]