[Bug build/34411] New: [pre-commit] Don't use types filtering

https://sourceware.org/bugzilla/show_bug.cgi?id=34411

            Bug ID: 34411
           Summary: [pre-commit] Don't use types filtering
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

Pre-commit hooks run on files that match both the files and types filters.

The files filter uses fields files and exclude.

The types filter uses fields types, types_or and types_exclude.

The default values for the types filter fields are:
- types: [file]
- types_or: []
- types_exclude: []

There are a few hooks that limit types to something more strict than [file].

Codespell's .pre-commit-hooks.yaml uses [text].

Our local check-whitespace hook also uses [text].

These tools run from pre-commit may also be run independently:
- codespell may be run from the command line in an interactive session
  (-i 3 -w)
- git diff commands on the CLI also need info about binary/text characteristics
  of files

For consistency, it would be best not to use types filtering, and instead to
implement all the filtering outside the pre-commit setup.

-- 
You are receiving this mail because:
You are on the CC list for the bug.