[Bug testsuite/33945] [gdb/testsuite, insufficient pre-commit version] FAIL: gdb.src/pre-commit.exp: pre-commit checks
"cvs-commit at gcc dot gnu.org via Gdb-prs" <[email protected]>
| Newsgroups | gmane.comp.gdb.bugs.discuss |
|---|---|
| Message-ID | <[email protected]/bugzilla/> |
https://sourceware.org/bugzilla/show_bug.cgi?id=33945 --- Comment #1 from Sourceware Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Tom de Vries <[email protected]>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=06efd870fd48185b703762dc775b04c089b114ff commit 06efd870fd48185b703762dc775b04c089b114ff Author: Tom de Vries <[email protected]> Date: Tue Jul 21 22:52:42 2026 +0200 [gdb/testsuite] Improve gdb.src/pre-commit.exp Test-case gdb.src/pre-commit.exp runs all the pre-commit stage hooks, but produces a single pass: ... PASS: gdb.src/pre-commit.exp: pre-commit checks ... Use a dummy run to find all the hooks, and then run them one by one, producing instead the more informative: ... PASS: gdb.src/pre-commit.exp: pre-commit: black: run PASS: gdb.src/pre-commit.exp: pre-commit: flake8: run PASS: gdb.src/pre-commit.exp: pre-commit: isort: run PASS: gdb.src/pre-commit.exp: pre-commit: codespell: run PASS: gdb.src/pre-commit.exp: pre-commit: tclint: run PASS: gdb.src/pre-commit.exp: pre-commit: check-include-guards: run PASS: gdb.src/pre-commit.exp: pre-commit: check-whitespace: run PASS: gdb.src/pre-commit.exp: pre-commit: check-file-mode: run ... This allows us to get rid of the current SKIP kludge for the pre-commit-setup hook. Also skip the gnu-check-style hook, since it only checks patches, not files. While we're at it, also bail out with unsupported if the pre-commit version is too old, fixing PR testsuite/33945. Approved-By: Tom Tromey <[email protected]> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33945 -- You are receiving this mail because: You are on the CC list for the bug.