[binutils-gdb] gdb: change gdbarch_print_registers_info parameter to bool
Simon Marchi via Gdb-cvs <[email protected]>
| Newsgroups | gmane.comp.gdb.cvs |
|---|---|
| Message-ID | <[email protected]> |
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5452abae845bbeab3cdc38264f8887ce0ddd1634 commit 5452abae845bbeab3cdc38264f8887ce0ddd1634 Author: Simon Marchi <[email protected]> Date: Mon Mar 9 14:31:43 2026 -0400 gdb: change gdbarch_print_registers_info parameter to bool Straightforward int to bool conversion. Change-Id: I27a35bb46c108474555cbad22fc33f0b4bcf7b51 Approved-By: Tom Tromey <[email protected]> Diff: --- gdb/gdbarch-gen.c | 2 +- gdb/gdbarch-gen.h | 4 ++-- gdb/gdbarch_components.py | 2 +- gdb/h8300-tdep.c | 2 +- gdb/infcmd.c | 8 ++++---- gdb/inferior.h | 4 ++-- gdb/m68hc11-tdep.c | 3 ++- gdb/mips-tdep.c | 2 +- gdb/riscv-tdep.c | 2 +- gdb/s12z-tdep.c | 2 +- gdb/tui/tui-regs.c | 2 +- 11 files changed, 17 insertions(+), 16 deletions(-) diff --git a/gdb/gdbarch-gen.c b/gdb/gdbarch-gen.c index d822812e72c..5c524d58cc3 100644 --- a/gdb/gdbarch-gen.c +++ b/gdb/gdbarch-gen.c @@ -2249,7 +2249,7 @@ set_gdbarch_code_of_frame_writable (struct gdbarch *gdbarch, } void -gdbarch_print_registers_info (struct gdbarch *gdbarch, struct ui_file *file, const frame_info_ptr &frame, int regnum, int all) +gdbarch_print_registers_info (struct gdbarch *gdbarch, struct ui_file *file, const frame_info_ptr &frame, int regnum, bool all) { gdb_assert (gdbarch != nullptr); gdb_assert (gdbarch->print_registers_info != nullptr); diff --git a/gdb/gdbarch-gen.h b/gdb/gdbarch-gen.h index 7bae19fc0f6..0c15a86765a 100644 --- a/gdb/gdbarch-gen.h +++ b/gdb/gdbarch-gen.h @@ -351,8 +351,8 @@ using gdbarch_code_of_frame_writable_ftype = bool (struct gdbarch *gdbarch, cons bool gdbarch_code_of_frame_writable (struct gdbarch *gdbarch, const frame_info_ptr &frame); void set_gdbarch_code_of_frame_writable (struct gdbarch *gdbarch, gdbarch_code_of_frame_writable_ftype *code_of_frame_writable); -using gdbarch_print_registers_info_ftype = void (struct gdbarch *gdbarch, struct ui_file *file, const frame_info_ptr &frame, int regnum, int all); -void gdbarch_print_registers_info (struct gdbarch *gdbarch, struct ui_file *file, const frame_info_ptr &frame, int regnum, int all); +using gdbarch_print_registers_info_ftype = void (struct gdbarch *gdbarch, struct ui_file *file, const frame_info_ptr &frame, int regnum, bool all); +void gdbarch_print_registers_info (struct gdbarch *gdbarch, struct ui_file *file, const frame_info_ptr &frame, int regnum, bool all); void set_gdbarch_print_registers_info (struct gdbarch *gdbarch, gdbarch_print_registers_info_ftype *print_registers_info); using gdbarch_print_float_info_ftype = void (struct gdbarch *gdbarch, struct ui_file *file, const frame_info_ptr &frame, const char *args); diff --git a/gdb/gdbarch_components.py b/gdb/gdbarch_components.py index de4335f1515..b1cff8c2b69 100644 --- a/gdb/gdbarch_components.py +++ b/gdb/gdbarch_components.py @@ -677,7 +677,7 @@ Method( ("struct ui_file *", "file"), ("const frame_info_ptr &", "frame"), ("int", "regnum"), - ("int", "all"), + ("bool", "all"), ], predefault="default_print_registers_info", invalid=False, diff --git a/gdb/h8300-tdep.c b/gdb/h8300-tdep.c index 1846f79e313..086bf69b0ed 100644 --- a/gdb/h8300-tdep.c +++ b/gdb/h8300-tdep.c @@ -1068,7 +1068,7 @@ h8300_print_register (struct gdbarch *gdbarch, struct ui_file *file, static void h8300_print_registers_info (struct gdbarch *gdbarch, struct ui_file *file, - const frame_info_ptr &frame, int regno, int cpregs) + const frame_info_ptr &frame, int regno, bool cpregs) { if (regno < 0) { diff --git a/gdb/infcmd.c b/gdb/infcmd.c index d0d1c142041..9fbee5aaba7 100644 --- a/gdb/infcmd.c +++ b/gdb/infcmd.c @@ -2475,7 +2475,7 @@ void default_print_registers_info (struct gdbarch *gdbarch, struct ui_file *file, const frame_info_ptr &frame, - int regnum, int print_all) + int regnum, bool print_all) { int i; const int numregs = gdbarch_num_cooked_regs (gdbarch); @@ -2516,7 +2516,7 @@ default_print_registers_info (struct gdbarch *gdbarch, } void -registers_info (const char *addr_exp, int fpregs) +registers_info (const char *addr_exp, bool fpregs) { frame_info_ptr frame; struct gdbarch *gdbarch; @@ -2647,7 +2647,7 @@ print_vector_info (struct ui_file *file, if (gdbarch_register_reggroup_p (gdbarch, regnum, vector_reggroup)) { printed_something = true; - gdbarch_print_registers_info (gdbarch, file, frame, regnum, 1); + gdbarch_print_registers_info (gdbarch, file, frame, regnum, true); } } if (!printed_something) @@ -3177,7 +3177,7 @@ default_print_float_info (struct gdbarch *gdbarch, struct ui_file *file, if (gdbarch_register_reggroup_p (gdbarch, regnum, float_reggroup)) { printed_something = 1; - gdbarch_print_registers_info (gdbarch, file, frame, regnum, 1); + gdbarch_print_registers_info (gdbarch, file, frame, regnum, true); } } if (!printed_something) diff --git a/gdb/inferior.h b/gdb/inferior.h index a3d4842be2c..fbf9765fb0e 100644 --- a/gdb/inferior.h +++ b/gdb/inferior.h @@ -150,7 +150,7 @@ extern void reopen_exec_file (void); extern void default_print_registers_info (struct gdbarch *gdbarch, struct ui_file *file, const frame_info_ptr &frame, - int regnum, int all); + int regnum, bool all); /* Default implementation of gdbarch_print_float_info. Print the values of all floating point registers. */ @@ -223,7 +223,7 @@ extern void post_create_inferior (int from_tty, bool set_pspace_solib_ops); extern void attach_command (const char *, int); -extern void registers_info (const char *, int); +extern void registers_info (const char *, bool); extern void continue_1 (int all_threads); diff --git a/gdb/m68hc11-tdep.c b/gdb/m68hc11-tdep.c index 14a9c93e0e3..a036dc26eb6 100644 --- a/gdb/m68hc11-tdep.c +++ b/gdb/m68hc11-tdep.c @@ -1081,7 +1081,8 @@ m68hc11_print_register (struct gdbarch *gdbarch, struct ui_file *file, /* Same as 'info reg' but prints the registers in a different way. */ static void m68hc11_print_registers_info (struct gdbarch *gdbarch, struct ui_file *file, - const frame_info_ptr &frame, int regno, int cpregs) + const frame_info_ptr &frame, int regno, + bool cpregs) { if (regno >= 0) { diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c index 5a861035d67..161c94569a8 100644 --- a/gdb/mips-tdep.c +++ b/gdb/mips-tdep.c @@ -6623,7 +6623,7 @@ print_gp_register_row (struct ui_file *file, const frame_info_ptr &frame, static void mips_print_registers_info (struct gdbarch *gdbarch, struct ui_file *file, - const frame_info_ptr &frame, int regnum, int all) + const frame_info_ptr &frame, int regnum, bool all) { if (regnum != -1) /* Do one specified register. */ { diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c index 252c2e5042e..0d2cbd8cbe9 100644 --- a/gdb/riscv-tdep.c +++ b/gdb/riscv-tdep.c @@ -1520,7 +1520,7 @@ static void riscv_print_registers_info (struct gdbarch *gdbarch, struct ui_file *file, const frame_info_ptr &frame, - int regnum, int print_all) + int regnum, bool print_all) { if (regnum != -1) { diff --git a/gdb/s12z-tdep.c b/gdb/s12z-tdep.c index b95e9f20046..6ac0930e5b0 100644 --- a/gdb/s12z-tdep.c +++ b/gdb/s12z-tdep.c @@ -525,7 +525,7 @@ static void s12z_print_registers_info (struct gdbarch *gdbarch, struct ui_file *file, const frame_info_ptr &frame, - int regnum, int print_all) + int regnum, bool print_all) { const int numregs = (gdbarch_num_regs (gdbarch) + gdbarch_num_pseudo_regs (gdbarch)); diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c index 6059130fa53..28f0d8b82d4 100644 --- a/gdb/tui/tui-regs.c +++ b/gdb/tui/tui-regs.c @@ -47,7 +47,7 @@ tui_register_format (const frame_info_ptr &frame, int regnum) /* Expand tabs into spaces, since ncurses on MS-Windows doesn't. */ string_file stream; tab_expansion_file expander (&stream); - gdbarch_print_registers_info (gdbarch, &expander, frame, regnum, 1); + gdbarch_print_registers_info (gdbarch, &expander, frame, regnum, true); /* Remove the possible \n. */ std::string str = stream.release ();