[binutils-gdb] [gdb/ada] Use c_isupper in ada_decode

Tom de Vries via Gdb-cvs <[email protected]>
Newsgroups gmane.comp.gdb.cvs
Message-ID <[email protected]>
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=87d2019c27d8af59ce602ba162e7b11852d60f3b

commit 87d2019c27d8af59ce602ba162e7b11852d60f3b
Author: Tom de Vries <[email protected]>
Date:   Tue Mar 24 14:58:11 2026 +0100

    [gdb/ada] Use c_isupper in ada_decode
    
    Commit cfe3a766e64 ("Change ada_decode to preserve upper-case in some
    situations") changed a use of c_isupper into isupper:
    ...
    $ git show cfe3a766e646| grep isupper
    +      else if (isupper (encoded[i]) || encoded[i] == ' ')
    -       if (c_isupper (decoded[i]) || decoded[i] == ' ')
    ...
    
    Apparently this was an oversight [1].
    
    Fix this by using c_isupper.
    
    Tested on x86_64-linux.
    
    Approved-By: Tom Tromey <[email protected]>
    
    [1] https://sourceware.org/pipermail/gdb-patches/2026-March/226136.html

Diff:
---
 gdb/ada-lang.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 1d1c021a51a..2772ce820b2 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -1559,7 +1559,7 @@ ada_decode (const char *encoded, bool wrap, bool translate)
 	  at_start_name = 1;
 	  i += 2;
 	}
-      else if (isupper (encoded[i]) || encoded[i] == ' ')
+      else if (c_isupper (encoded[i]) || encoded[i] == ' ')
 	{
 	  /* Decoded names should never contain any uppercase
 	     character.  */
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.