[binutils-gdb] GDB: testsuite: reverse: Don't return value from top-level (manual)
Thiago Bauermann via Gdb-cvs <[email protected]>
| Newsgroups | gmane.comp.gdb.cvs |
|---|---|
| Message-ID | <[email protected]> |
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fc19d8e6e68d9eeb24f038af0119376f17d80510 commit fc19d8e6e68d9eeb24f038af0119376f17d80510 Author: Thiago Jung Bauermann <[email protected]> Date: Wed Apr 29 20:04:20 2026 -0300 GDB: testsuite: reverse: Don't return value from top-level (manual) This patch manually changes "return -1" statements that weren't caught by the sed command. It also changes a few "return 0" statements. These return statements fall into one of these criteria: - misaligned line, which is then fixed by this patch; - return at top level but inside block such as with_test_prefix, foreach_with_prefix, with_timeout_factor, gdb_test_multiple. Approved-By: Tom Tromey <[email protected]> Diff: --- gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp | 2 +- gdb/testsuite/gdb.reverse/func-map-to-same-line.exp | 2 +- gdb/testsuite/gdb.reverse/i386-sse-reverse.exp | 6 +++--- gdb/testsuite/gdb.reverse/maint-print-instruction.exp | 2 +- gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp | 2 +- gdb/testsuite/gdb.reverse/sigall-precsave.exp | 2 +- gdb/testsuite/gdb.reverse/sigall-reverse.exp | 2 +- gdb/testsuite/gdb.reverse/singlejmp-reverse.exp | 4 ++-- gdb/testsuite/gdb.reverse/solib-precsave.exp | 2 +- gdb/testsuite/gdb.reverse/solib-reverse.exp | 2 +- gdb/testsuite/gdb.reverse/until-precsave.exp | 2 +- gdb/testsuite/gdb.reverse/until-reverse.exp | 2 +- 12 files changed, 15 insertions(+), 15 deletions(-) diff --git a/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp b/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp index 19ebebf6a12..0432dd47cc0 100644 --- a/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp +++ b/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp @@ -49,7 +49,7 @@ if { [prepare_for_testing "failed to prepare" "$testfile" $srcfile] } { } if {![runto_main]} { - return 0 + return } if {[supports_process_record]} { diff --git a/gdb/testsuite/gdb.reverse/func-map-to-same-line.exp b/gdb/testsuite/gdb.reverse/func-map-to-same-line.exp index dd36528eb3e..76febe312f5 100644 --- a/gdb/testsuite/gdb.reverse/func-map-to-same-line.exp +++ b/gdb/testsuite/gdb.reverse/func-map-to-same-line.exp @@ -133,7 +133,7 @@ foreach_with_prefix column_info_flag {column-info no-column-info} { if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \ $options]} { - return -1 + return } run_tests diff --git a/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp b/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp index dc1308861e2..3ed1d7e6fae 100644 --- a/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp +++ b/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp @@ -64,7 +64,7 @@ gdb_test_multiple "continue" $test { } -re " Illegal instruction.*\r\n$gdb_prompt $" { untested i386-sse-reverse - return -1 + return } } @@ -590,7 +590,7 @@ gdb_test_multiple "continue" $test { } -re " Illegal instruction.*\r\n$gdb_prompt $" { untested i386-ssse3-reverse - return -1 + return } } @@ -666,7 +666,7 @@ gdb_test_multiple "continue" $test { } -re " Illegal instruction.*\r\n$gdb_prompt $" { untested i386-sse4-reverse - return -1 + return } } diff --git a/gdb/testsuite/gdb.reverse/maint-print-instruction.exp b/gdb/testsuite/gdb.reverse/maint-print-instruction.exp index ad8009b415a..edf6ec081cd 100644 --- a/gdb/testsuite/gdb.reverse/maint-print-instruction.exp +++ b/gdb/testsuite/gdb.reverse/maint-print-instruction.exp @@ -46,7 +46,7 @@ proc test_print { has_history level test_name } { } if { ![runto_main] } { - return 0 + return } #confirm that GDB doesn't go crazy if recording isn't enabled diff --git a/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp b/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp index d34fe130e8e..b175774aee4 100644 --- a/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp +++ b/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp @@ -49,7 +49,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { } if {![runto_main]} { - return 0 + return } if {[supports_process_record]} { diff --git a/gdb/testsuite/gdb.reverse/sigall-precsave.exp b/gdb/testsuite/gdb.reverse/sigall-precsave.exp index d8bc6dfaccf..5ce7de0ea1f 100644 --- a/gdb/testsuite/gdb.reverse/sigall-precsave.exp +++ b/gdb/testsuite/gdb.reverse/sigall-precsave.exp @@ -258,7 +258,7 @@ gdb_test_multiple "continue" "run to end of main" { } -wrap -re "Process record does not support instruction 0xfae64 at.*" { kfail "gdb/25038" $gdb_test_name - return -1 + return } } diff --git a/gdb/testsuite/gdb.reverse/sigall-reverse.exp b/gdb/testsuite/gdb.reverse/sigall-reverse.exp index 2dae1933d81..45bb49ecfeb 100644 --- a/gdb/testsuite/gdb.reverse/sigall-reverse.exp +++ b/gdb/testsuite/gdb.reverse/sigall-reverse.exp @@ -239,7 +239,7 @@ with_test_prefix "sig-test-1" { foreach sig [lrange $signals 1 end] { test_one_sig $sig if { $record_instruction_kfail } { - return -1 + return } } } diff --git a/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp b/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp index 830292cd666..dfa8ac179f0 100644 --- a/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp +++ b/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp @@ -24,13 +24,13 @@ if {[info exists COMPILE]} { ${testfile}.c {debug optimize=-O2} \ ${testfile}-nodebug.c {optimize=-O2} \ ] == -1 } { - return -1 + return } } else { require is_x86_64_m64_target if { [build_executable ${testfile}.exp ${testfile} \ [list ${srcfile} ${srcfile2}] {}] == -1 } { - return -1 + return } } diff --git a/gdb/testsuite/gdb.reverse/solib-precsave.exp b/gdb/testsuite/gdb.reverse/solib-precsave.exp index ef3229c7492..cad30320048 100644 --- a/gdb/testsuite/gdb.reverse/solib-precsave.exp +++ b/gdb/testsuite/gdb.reverse/solib-precsave.exp @@ -80,7 +80,7 @@ gdb_test_multiple "continue" "run to end of main" { } -wrap -re "Process record does not support instruction 0xfae64 at.*" { kfail "gdb/25038" $gdb_test_name - return -1 + return } } diff --git a/gdb/testsuite/gdb.reverse/solib-reverse.exp b/gdb/testsuite/gdb.reverse/solib-reverse.exp index c5a610fcb39..b5f49fb7299 100644 --- a/gdb/testsuite/gdb.reverse/solib-reverse.exp +++ b/gdb/testsuite/gdb.reverse/solib-reverse.exp @@ -77,7 +77,7 @@ gdb_test_multiple "until $end_part_one" "run until end part one" { } -wrap -re "Process record does not support instruction 0xfae64 at.*" { kfail "gdb/25038" $gdb_test_name - return -1 + return } } diff --git a/gdb/testsuite/gdb.reverse/until-precsave.exp b/gdb/testsuite/gdb.reverse/until-precsave.exp index 411fc14fed2..075a87dc2d8 100644 --- a/gdb/testsuite/gdb.reverse/until-precsave.exp +++ b/gdb/testsuite/gdb.reverse/until-precsave.exp @@ -52,7 +52,7 @@ with_timeout_factor 20 { } -wrap -re "Process record does not support instruction 0xfae64 at.*" { kfail "gdb/25038" $gdb_test_name - return -1 + return } } } diff --git a/gdb/testsuite/gdb.reverse/until-reverse.exp b/gdb/testsuite/gdb.reverse/until-reverse.exp index 74703223c64..19ec2fee6b0 100644 --- a/gdb/testsuite/gdb.reverse/until-reverse.exp +++ b/gdb/testsuite/gdb.reverse/until-reverse.exp @@ -53,7 +53,7 @@ gdb_test_multiple "advance factorial" "" { } -wrap -re "Process record does not support instruction 0xfae64 at.*" { kfail "gdb/25038" $gdb_test_name - return -1 + return } }