[binutils-gdb] GDB: testsuite: TUI: Don't return -1 from top-level (sed)
Thiago Bauermann via Gdb-cvs <[email protected]>
| Newsgroups | gmane.comp.gdb.cvs |
|---|---|
| Message-ID | <[email protected]> |
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=51f8decb2fc1b60da42a3619434a65bbb7a65ef3 commit 51f8decb2fc1b60da42a3619434a65bbb7a65ef3 Author: Thiago Jung Bauermann <[email protected]> Date: Wed Apr 29 20:04:26 2026 -0300 GDB: testsuite: TUI: Don't return -1 from top-level (sed) This patch is purely the result of running: $ sed -i 's/^ return -1/ return/' *.exp* inside gdb/testsuite/gdb.tui. Approved-By: Tom Tromey <[email protected]> Diff: --- gdb/testsuite/gdb.tui/basic.exp | 2 +- gdb/testsuite/gdb.tui/break.exp | 2 +- gdb/testsuite/gdb.tui/compact-source.exp | 2 +- gdb/testsuite/gdb.tui/corefile-run.exp | 6 +++--- gdb/testsuite/gdb.tui/flush-after-run.exp | 2 +- gdb/testsuite/gdb.tui/list-before.exp | 2 +- gdb/testsuite/gdb.tui/list.exp | 2 +- gdb/testsuite/gdb.tui/main-2.exp | 2 +- gdb/testsuite/gdb.tui/main.exp | 2 +- gdb/testsuite/gdb.tui/new-layout.exp | 2 +- gdb/testsuite/gdb.tui/regs.exp | 2 +- gdb/testsuite/gdb.tui/reread.exp | 2 +- gdb/testsuite/gdb.tui/resize-3.exp | 2 +- gdb/testsuite/gdb.tui/resize-one-line.exp | 2 +- gdb/testsuite/gdb.tui/resize.exp | 2 +- gdb/testsuite/gdb.tui/scroll.exp | 2 +- gdb/testsuite/gdb.tui/tui-focus.exp | 2 +- gdb/testsuite/gdb.tui/tui-init-source.exp | 2 +- gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp | 2 +- gdb/testsuite/gdb.tui/tui-layout-asm.exp | 2 +- gdb/testsuite/gdb.tui/tui-layout.exp | 2 +- gdb/testsuite/gdb.tui/winheight.exp | 2 +- gdb/testsuite/gdb.tui/winwidth.exp | 2 +- 23 files changed, 25 insertions(+), 25 deletions(-) diff --git a/gdb/testsuite/gdb.tui/basic.exp b/gdb/testsuite/gdb.tui/basic.exp index 7909cea674d..26264082a16 100644 --- a/gdb/testsuite/gdb.tui/basic.exp +++ b/gdb/testsuite/gdb.tui/basic.exp @@ -24,7 +24,7 @@ standard_testfile main-one-line.c set main_line [gdb_get_line_number "int main"] if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } Term::clean_restart 24 80 $testfile diff --git a/gdb/testsuite/gdb.tui/break.exp b/gdb/testsuite/gdb.tui/break.exp index 4e07a0c0b69..154ca40b69f 100644 --- a/gdb/testsuite/gdb.tui/break.exp +++ b/gdb/testsuite/gdb.tui/break.exp @@ -20,7 +20,7 @@ tuiterm_env standard_testfile tui-layout.c if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } Term::clean_restart 24 80 $testfile diff --git a/gdb/testsuite/gdb.tui/compact-source.exp b/gdb/testsuite/gdb.tui/compact-source.exp index 9f41a160b3f..e9478bbeb86 100644 --- a/gdb/testsuite/gdb.tui/compact-source.exp +++ b/gdb/testsuite/gdb.tui/compact-source.exp @@ -38,7 +38,7 @@ puts $fd $src_txt close $fd if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } Term::clean_restart 24 80 $testfile diff --git a/gdb/testsuite/gdb.tui/corefile-run.exp b/gdb/testsuite/gdb.tui/corefile-run.exp index 7e1184ecf04..1361e4a7f6d 100644 --- a/gdb/testsuite/gdb.tui/corefile-run.exp +++ b/gdb/testsuite/gdb.tui/corefile-run.exp @@ -27,19 +27,19 @@ standard_testfile tui-layout.c set core [standard_output_file "${testfile}.core"] if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } { - return -1 + return } # Only run on native boards. require {target_can_use_run_cmd core} if { ![runto_main] } { - return -1 + return } if { ![gdb_gcore_cmd "$core" "save a corefile"] } { untested "could not generate a corefile" - return -1 + return } set src_line "return 0;" diff --git a/gdb/testsuite/gdb.tui/flush-after-run.exp b/gdb/testsuite/gdb.tui/flush-after-run.exp index ecc2caafc33..db20b8cee80 100644 --- a/gdb/testsuite/gdb.tui/flush-after-run.exp +++ b/gdb/testsuite/gdb.tui/flush-after-run.exp @@ -24,7 +24,7 @@ tuiterm_env standard_testfile if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } Term::clean_restart 24 80 $testfile diff --git a/gdb/testsuite/gdb.tui/list-before.exp b/gdb/testsuite/gdb.tui/list-before.exp index 55485aa5629..5d3cef954d4 100644 --- a/gdb/testsuite/gdb.tui/list-before.exp +++ b/gdb/testsuite/gdb.tui/list-before.exp @@ -20,7 +20,7 @@ tuiterm_env standard_testfile tui-layout.c if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } Term::clean_restart 24 80 $testfile diff --git a/gdb/testsuite/gdb.tui/list.exp b/gdb/testsuite/gdb.tui/list.exp index de58afa53e1..5cefebc7e01 100644 --- a/gdb/testsuite/gdb.tui/list.exp +++ b/gdb/testsuite/gdb.tui/list.exp @@ -20,7 +20,7 @@ tuiterm_env standard_testfile tui-layout.c if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } Term::clean_restart 24 80 $testfile diff --git a/gdb/testsuite/gdb.tui/main-2.exp b/gdb/testsuite/gdb.tui/main-2.exp index 1b8068e3a36..9b3b38645b0 100644 --- a/gdb/testsuite/gdb.tui/main-2.exp +++ b/gdb/testsuite/gdb.tui/main-2.exp @@ -23,7 +23,7 @@ tuiterm_env standard_testfile tui-layout.c if { [build_executable "failed to prepare" $testfile $srcfile ] == -1} { - return -1 + return } Term::clean_restart 24 80 $testfile diff --git a/gdb/testsuite/gdb.tui/main.exp b/gdb/testsuite/gdb.tui/main.exp index 5bc6b91cdee..d8a9c8eebe8 100644 --- a/gdb/testsuite/gdb.tui/main.exp +++ b/gdb/testsuite/gdb.tui/main.exp @@ -22,7 +22,7 @@ tuiterm_env standard_testfile tui-layout.c if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } # Note: don't pass the executable here diff --git a/gdb/testsuite/gdb.tui/new-layout.exp b/gdb/testsuite/gdb.tui/new-layout.exp index f293773f9d1..e544ef6fd90 100644 --- a/gdb/testsuite/gdb.tui/new-layout.exp +++ b/gdb/testsuite/gdb.tui/new-layout.exp @@ -20,7 +20,7 @@ tuiterm_env standard_testfile tui-layout.c if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } # Make sure TUI is supported before continuing. diff --git a/gdb/testsuite/gdb.tui/regs.exp b/gdb/testsuite/gdb.tui/regs.exp index 3c524ad49a7..8169538da85 100644 --- a/gdb/testsuite/gdb.tui/regs.exp +++ b/gdb/testsuite/gdb.tui/regs.exp @@ -20,7 +20,7 @@ tuiterm_env standard_testfile tui-layout.c if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } Term::clean_restart 24 80 $testfile diff --git a/gdb/testsuite/gdb.tui/reread.exp b/gdb/testsuite/gdb.tui/reread.exp index de35fef744c..3ed0839e1c8 100644 --- a/gdb/testsuite/gdb.tui/reread.exp +++ b/gdb/testsuite/gdb.tui/reread.exp @@ -23,7 +23,7 @@ tuiterm_env standard_testfile main-one-line.c if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } Term::clean_restart 24 80 $testfile diff --git a/gdb/testsuite/gdb.tui/resize-3.exp b/gdb/testsuite/gdb.tui/resize-3.exp index d9e0948a9a8..fdaffe00641 100644 --- a/gdb/testsuite/gdb.tui/resize-3.exp +++ b/gdb/testsuite/gdb.tui/resize-3.exp @@ -23,7 +23,7 @@ if { [build_executable_from_specs "failed to prepare" \ $testfile {debug} \ $srcfile {debug} \ $srcfile2 {nodebug}] == -1 } { - return -1 + return } tuiterm_env diff --git a/gdb/testsuite/gdb.tui/resize-one-line.exp b/gdb/testsuite/gdb.tui/resize-one-line.exp index f5e2858b05d..0a47dcf0e7f 100644 --- a/gdb/testsuite/gdb.tui/resize-one-line.exp +++ b/gdb/testsuite/gdb.tui/resize-one-line.exp @@ -22,7 +22,7 @@ tuiterm_env standard_testfile main-one-line.c if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } Term::clean_restart 24 80 $testfile diff --git a/gdb/testsuite/gdb.tui/resize.exp b/gdb/testsuite/gdb.tui/resize.exp index 93918f3b356..25f52c6a5b8 100644 --- a/gdb/testsuite/gdb.tui/resize.exp +++ b/gdb/testsuite/gdb.tui/resize.exp @@ -20,7 +20,7 @@ tuiterm_env standard_testfile tui-layout.c if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } Term::clean_restart 24 80 $testfile diff --git a/gdb/testsuite/gdb.tui/scroll.exp b/gdb/testsuite/gdb.tui/scroll.exp index e9fa829f40e..0162cfd8db7 100644 --- a/gdb/testsuite/gdb.tui/scroll.exp +++ b/gdb/testsuite/gdb.tui/scroll.exp @@ -24,7 +24,7 @@ tuiterm_env standard_testfile tui-layout.c if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } Term::clean_restart 24 80 $testfile diff --git a/gdb/testsuite/gdb.tui/tui-focus.exp b/gdb/testsuite/gdb.tui/tui-focus.exp index 5df76b59b86..310b3a47320 100644 --- a/gdb/testsuite/gdb.tui/tui-focus.exp +++ b/gdb/testsuite/gdb.tui/tui-focus.exp @@ -23,7 +23,7 @@ load_lib gdb-python.exp standard_testfile if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile}]} { - return -1 + return } # Run a series of tests based on various test specifications. diff --git a/gdb/testsuite/gdb.tui/tui-init-source.exp b/gdb/testsuite/gdb.tui/tui-init-source.exp index edd364e05b1..f49b0ecdcbd 100644 --- a/gdb/testsuite/gdb.tui/tui-init-source.exp +++ b/gdb/testsuite/gdb.tui/tui-init-source.exp @@ -23,7 +23,7 @@ tuiterm_env standard_testfile if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } Term::clean_restart 24 80 $testfile diff --git a/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp b/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp index e54ae69997e..b3dd72ce1ce 100644 --- a/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp +++ b/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp @@ -27,7 +27,7 @@ lappend opts additional_flags=-nostdlib lappend opts ldflags=-nostartfiles if { [build_executable "failed to prepare" $testfile $srcfile $opts] == -1 } { - return -1 + return } Term::clean_restart 24 80 $testfile diff --git a/gdb/testsuite/gdb.tui/tui-layout-asm.exp b/gdb/testsuite/gdb.tui/tui-layout-asm.exp index bbaa4f9b846..01193b6fb44 100644 --- a/gdb/testsuite/gdb.tui/tui-layout-asm.exp +++ b/gdb/testsuite/gdb.tui/tui-layout-asm.exp @@ -21,7 +21,7 @@ tuiterm_env standard_testfile tui-layout.c if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } # The wider the window is, the less line truncation happens, so matching diff --git a/gdb/testsuite/gdb.tui/tui-layout.exp b/gdb/testsuite/gdb.tui/tui-layout.exp index 05ca3b45029..1cb70504e3f 100644 --- a/gdb/testsuite/gdb.tui/tui-layout.exp +++ b/gdb/testsuite/gdb.tui/tui-layout.exp @@ -23,7 +23,7 @@ tuiterm_env standard_testfile if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile}]} { - return -1 + return } # Run one test of the 'layout' command, selecting LAYOUT_NAME. diff --git a/gdb/testsuite/gdb.tui/winheight.exp b/gdb/testsuite/gdb.tui/winheight.exp index 758f23d8f72..9daf08916af 100644 --- a/gdb/testsuite/gdb.tui/winheight.exp +++ b/gdb/testsuite/gdb.tui/winheight.exp @@ -20,7 +20,7 @@ tuiterm_env standard_testfile tui-layout.c if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } Term::clean_restart 24 80 $testfile diff --git a/gdb/testsuite/gdb.tui/winwidth.exp b/gdb/testsuite/gdb.tui/winwidth.exp index a18ff4edba1..cc6c7dcd153 100644 --- a/gdb/testsuite/gdb.tui/winwidth.exp +++ b/gdb/testsuite/gdb.tui/winwidth.exp @@ -20,7 +20,7 @@ tuiterm_env standard_testfile tui-layout.c if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} { - return -1 + return } Term::clean_restart 24 80 $testfile