[binutils-gdb] gdb: update store_integer's comment

Markus Metzger via Gdb-cvs <[email protected]>
Newsgroups gmane.comp.gdb.cvs
Message-ID <[email protected]>
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9c16e272180d38bcdc9ab11e812102db8b88a87e

commit 9c16e272180d38bcdc9ab11e812102db8b88a87e
Author: Tankut Baris Aktemur <[email protected]>
Date:   Thu Jan 8 15:16:09 2026 +0000

    gdb: update store_integer's comment
    
    The comment of store_integer seems slightly outdated and does not refer to
    the variants that take an array view.  Update the comment and add comments
    to the various instantiations.
    
    Approved-By: Simon Marchi <[email protected]>

Diff:
---
 gdb/extract-store-integer.c |  4 ++--
 gdb/extract-store-integer.h | 19 +++++++++++++++++--
 2 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/gdb/extract-store-integer.c b/gdb/extract-store-integer.c
index a7bce99362d..67e4534a27d 100644
--- a/gdb/extract-store-integer.c
+++ b/gdb/extract-store-integer.c
@@ -129,8 +129,8 @@ extract_typed_address (const gdb_byte *buf, struct type *type)
   return gdbarch_pointer_to_address (type->arch (), type, buf);
 }
 
-/* All 'store' functions accept a host-format integer and store a
-   target-format integer at ADDR which is LEN bytes long.  */
+/* See extract-store-integer.h.  */
+
 template<typename T, typename>
 void
 store_integer (gdb::array_view<gdb_byte> dst, enum bfd_endian byte_order,
diff --git a/gdb/extract-store-integer.h b/gdb/extract-store-integer.h
index 76dfd49d62a..b6f734d23a7 100644
--- a/gdb/extract-store-integer.h
+++ b/gdb/extract-store-integer.h
@@ -56,13 +56,16 @@ extract_unsigned_integer (const gdb_byte *addr, int len,
 extern CORE_ADDR extract_typed_address (const gdb_byte *buf,
 					struct type *type);
 
-/* All 'store' functions accept a host-format integer and store a
-   target-format integer at ADDR which is LEN bytes long.  */
+/* Take host-format integer VAL and store it as target-format integer at
+   DST.  */
 
 template<typename T, typename = RequireLongest<T>>
 extern void store_integer (gdb::array_view<gdb_byte> dst,
 			   bfd_endian byte_order, T val);
 
+/* Take host-format integer VAL and store it as target-format integer at
+   ADDR which is LEN bytes long.  */
+
 template<typename T>
 static inline void
 store_integer (gdb_byte *addr, int len, bfd_endian byte_order, T val)
@@ -70,6 +73,9 @@ store_integer (gdb_byte *addr, int len, bfd_endian byte_order, T val)
   return store_integer (gdb::make_array_view (addr, len), byte_order, val);
 }
 
+/* Take host-format signed integer VAL and store it as target-format
+   signed integer at DST.  */
+
 static inline void
 store_signed_integer (gdb::array_view<gdb_byte> dst, bfd_endian byte_order,
 		      LONGEST val)
@@ -77,6 +83,9 @@ store_signed_integer (gdb::array_view<gdb_byte> dst, bfd_endian byte_order,
   return store_integer (dst, byte_order, val);
 }
 
+/* Take host-format signed integer VAL and store it as target-format
+   signed integer at ADDR which is LEN bytes long.  */
+
 static inline void
 store_signed_integer (gdb_byte *addr, int len, bfd_endian byte_order,
 		      LONGEST val)
@@ -85,6 +94,9 @@ store_signed_integer (gdb_byte *addr, int len, bfd_endian byte_order,
 			       val);
 }
 
+/* Take host-format unsigned integer VAL and store it as target-format
+   unsigned integer at DST.  */
+
 static inline void
 store_unsigned_integer (gdb::array_view<gdb_byte> dst, bfd_endian byte_order,
 			ULONGEST val)
@@ -92,6 +104,9 @@ store_unsigned_integer (gdb::array_view<gdb_byte> dst, bfd_endian byte_order,
   return store_integer (dst, byte_order, val);
 }
 
+/* Take host-format unsigned integer VAL and store it as target-format
+   unsigned integer at ADDR which is LEN bytes long.  */
+
 static inline void
 store_unsigned_integer (gdb_byte *addr, int len, bfd_endian byte_order,
 			ULONGEST val)
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.