[binutils-gdb] Windows gdb+gdbserver: Share exit status logic
Pedro Alves via Gdb-cvs <[email protected]> Fri, 12 Jun 2026 13:59:25 +0000 (GMT)
| Newsgroups | gmane.comp.gdb.cvs |
|---|---|
| Message-ID | <[email protected]> |
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4fce4baa748ff16ff427b5b5f010e02cb80f48d1 commit 4fce4baa748ff16ff427b5b5f010e02cb80f48d1 Author: Pedro Alves <[email protected]> Date: Wed May 20 11:45:57 2026 +0100 Windows gdb+gdbserver: Share exit status logic Move the exit status logic added by commit 559e7e5056 ("Improve process exit status macros on MinGW") from both GDB and GDBserver to a shared routine used by both. The next patch extends this routine with Cygwin-specific decoding. Change-Id: I4bf08c6beff0d1688064a81d49bbdd615643735e Diff: --- gdb/nat/windows-nat.c | 24 ++++++++++++++++++++++++ gdb/nat/windows-nat.h | 6 ++++++ gdb/windows-nat.c | 15 +++------------ gdbserver/win32-low.cc | 16 +++------------- 4 files changed, 36 insertions(+), 25 deletions(-) diff --git a/gdb/nat/windows-nat.c b/gdb/nat/windows-nat.c index b093acda342..92f9394ca6d 100644 --- a/gdb/nat/windows-nat.c +++ b/gdb/nat/windows-nat.c @@ -18,6 +18,8 @@ #include "nat/windows-nat.h" #include "gdbsupport/common-debug.h" +#include "gdbsupport/gdb_signals.h" +#include "gdbsupport/gdb_wait.h" #include "target/target.h" #undef GetModuleFileNameEx @@ -694,6 +696,28 @@ windows_process_info::add_all_dlls () /* See nat/windows-nat.h. */ +target_waitstatus +windows_process_info::exit_process_to_target_status + (const EXIT_PROCESS_DEBUG_INFO &info) +{ + DWORD exit_code = info.dwExitCode; + target_waitstatus tstatus; + + /* If the exit status looks like a fatal exception, but we don't + recognize the exception's code, make the original exit status + value available, to avoid losing information. */ + int exit_signal + = WIFSIGNALED (exit_code) ? WTERMSIG (exit_code) : -1; + if (exit_signal == -1) + tstatus.set_exited (exit_code); + else + tstatus.set_signalled (gdb_signal_from_host (exit_signal)); + + return tstatus; +} + +/* See nat/windows-nat.h. */ + std::string event_code_to_string (DWORD event_code) { diff --git a/gdb/nat/windows-nat.h b/gdb/nat/windows-nat.h index 2b239787126..d842fa850e6 100644 --- a/gdb/nat/windows-nat.h +++ b/gdb/nat/windows-nat.h @@ -315,6 +315,12 @@ struct windows_process_info }); } + /* Convert an EXIT_PROCESS_DEBUG_EVENT payload to a target wait + status. */ + + target_waitstatus exit_process_to_target_status + (const EXIT_PROCESS_DEBUG_INFO &info); + private: /* Handle MS_VC_EXCEPTION when processing a stop. MS_VC_EXCEPTION is diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index a7cf8692d41..1f82dee0e49 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -62,7 +62,6 @@ #include "complaints.h" #include "gdbsupport/gdb_tilde_expand.h" #include "gdbsupport/pathstuff.h" -#include "gdbsupport/gdb_wait.h" #include "gdbsupport/symbol.h" #include "inf-loop.h" @@ -1610,17 +1609,9 @@ windows_nat_target::get_windows_debug_event } else if (windows_process->saw_create == 1) { - DWORD exit_status = current_event->u.ExitProcess.dwExitCode; - /* If the exit status looks like a fatal exception, but we - don't recognize the exception's code, make the original - exit status value available, to avoid losing - information. */ - int exit_signal - = WIFSIGNALED (exit_status) ? WTERMSIG (exit_status) : -1; - if (exit_signal == -1) - ourstatus->set_exited (exit_status); - else - ourstatus->set_signalled (gdb_signal_from_host (exit_signal)); + *ourstatus + = (windows_process->exit_process_to_target_status + (current_event->u.ExitProcess)); thread_id = current_event->dwThreadId; diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc index 1931c66871f..511e034cb71 100644 --- a/gdbserver/win32-low.cc +++ b/gdbserver/win32-low.cc @@ -33,7 +33,6 @@ #include <process.h> #include "gdbsupport/gdb_tilde_expand.h" #include "gdbsupport/common-inferior.h" -#include "gdbsupport/gdb_wait.h" using namespace windows_nat; @@ -1061,18 +1060,9 @@ get_child_debug_event (DWORD *continue_status, break; case EXIT_PROCESS_DEBUG_EVENT: - { - DWORD exit_status = current_event->u.ExitProcess.dwExitCode; - /* If the exit status looks like a fatal exception, but we - don't recognize the exception's code, make the original - exit status value available, to avoid losing information. */ - int exit_signal - = WIFSIGNALED (exit_status) ? WTERMSIG (exit_status) : -1; - if (exit_signal == -1) - ourstatus->set_exited (exit_status); - else - ourstatus->set_signalled (gdb_signal_from_host (exit_signal)); - } + *ourstatus + = (windows_process.exit_process_to_target_status + (current_event->u.ExitProcess)); continue_last_debug_event (DBG_CONTINUE, debug_threads); break;