[binutils-gdb] gdb/testsuite: missing ';' in check-all-boards rule
Andrew Burgess via Gdb-cvs <[email protected]> Thu, 23 Jul 2026 16:42:35 +0000 (GMT)
| Newsgroups | gmane.comp.gdb.cvs |
|---|---|
| Message-ID | <[email protected]> |
https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dcb849b8f375d= 051666f063bfa21ecf4744d2fd0b commit cb849b8f375d051666f063bfa21ecf4744d2fd0b Author: Andrew Burgess <[email protected]> Date: Sat Jul 18 11:53:46 2026 +0100 gdb/testsuite: missing ';' in check-all-boards rule =20 The check-all-boards makefile rule was missing a semicolon. As a result we would pass "result=3D0" through to the make-check-all.sh script. =20 This 'result=3D0' would end up inside the TESTS=3D"..." string which was passed to the 'make check-...' command. As 'result=3D0' doesn't match any of GDB's .exp files the 'result=3D0' would then be ignored. =20 Back in the Makefile, due to the missing semicolon, as the 'result=3D...' line had become an extra argument to make-check-all.sh, we were no longer capturing the exit status of the make-check-all.sh script. This means that when the 'check-all-boards' rule completed we actually exited with the exit status of the last command rather than with the exit status of the make-check-all.sh script. =20 Fix this by adding in the missing semicolon. =20 There should be no changes in what is tested after this commit. =20 Approved-By: Tom Tromey <[email protected]> Diff: --- gdb/testsuite/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in index f103d7ddd65..44c710f8de9 100644 --- a/gdb/testsuite/Makefile.in +++ b/gdb/testsuite/Makefile.in @@ -386,7 +386,7 @@ check-all-boards: all $(abs_builddir)/site.exp ${abs_srcdir}/make-check-all.sh --keep-results \ --host-user "$(GDB_HOST_USERNAME)" \ --target-user "$(GDB_TARGET_USERNAME)" \ - "$(TESTS)" \ + "$(TESTS)"; \ result=3D$$?; \ if test -d check-all; then \ $(SHELL) $(srcdir)/../../contrib/dg-extract-results.sh \