Re: Get longjmp target check in breakpoint.c - is it necessary?

Tiago Stürmer Daitx <[email protected]> Thu, 31 Oct 2013 12:46:40 -0200

Newsgroups	gmane.comp.gdb.devel
Message-ID	<[email protected]>

On Thu, 2013-10-31 at 11:27 -0200, Edjunior Barbosa Machado wrote:

> What if you try to move this 'if' to a bit below in the function (right
> before "for (i = 0; i < NUM_LONGJMP_NAMES; i++)" loop)?

Good catch, I didn't notice the 'if' is kind of an optimization for the
scenarios where <arch>_get_longjmp_target is not provided. Moving it
down before that 'for NUM_LONGJMP_NAMES' loop would work nicely as
probes would work. 

The no changes were detected in the testsuite by moving the 'if' before
the 'for' compared to removing it altogether.

Regards,
Tiago

-- 
Tiago Stürmer Daitx
[email protected]
IBM - Linux Technology Center