Re: [RFC] BFD MinGW/Cygwin build error in bfd/peiXXgen.c

Pedro Alves <[email protected]> Wed, 18 Dec 2013 17:56:00 +0000

Newsgroups	gmane.comp.gnu.binutils,gmane.comp.gdb.devel
Message-ID	<[email protected]>

On 12/18/2013 01:02 PM, Pierre Muller wrote:
> -#ifdef __CYGWIN__
> +#if defined  __CYGWIN__ || defined __MINGW32__
> +#ifdef __MINGW32__
> +#define wcsncasecmp wcsnicmp
> +#endif
>    /* Under Cygwin unicode == UTF-16 == wchar_t.
>       FIXME: The same is true for MingGW - we should test for that too.  */

Isn't this FIXME note stale now?

> +  bfd_byte *    astring = a->name_id.name.string;
> +  unsigned int  alen    = a->name_id.name.len;
> +  bfd_byte *    bstring = b->name_id.name.string;
> +  unsigned int  blen    = b->name_id.name.len;
>    res = wcsncasecmp ((const wchar_t *) astring + 2, (const wchar_t *) bstring + 2, min (alen, blen));
>  #elif defined HAVE_WCHAR_H
>    unsigned int  i;

-- 
Pedro Alves