Re: Trailing Whitespace
Dmitry Samersoff <[email protected]>
| Newsgroups | gmane.comp.gdb.devel |
|---|---|
| Message-ID | <[email protected]> |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 IMHO, better approach is to install on-commit hook blocking commits with trailing whitespace (and tab characters) and leave old code as is. On 2014-01-09 19:01, Joel Brobecker wrote: >> Also (and I am not sure if git can get around this somehow) >> whitespace cleanups tend to obliterate diffs/patches that were >> written before the cleanup took place. This makes merging a >> massive pain. >> >> So my 2 pence worth is, no, not a good idea ;) > > Strongly seconded. Localized whitespace fixes are OK, because > manageable in the amount of work they generate, but please, not a > massive cleanup. And if we ever do that massive cleanup, I would > request that a pre-requisite is an "update" check on the git server > that rejects pushes of files violating that rule. > > On my end of things, I configured my editor to simply highlight > trailing spaces, not strip them. > - -- Dmitry Samersoff Saint Petersburg, Russia, http://devnull.samersoff.net * There will come soft rains ... -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJSzu57AAoJEHEy08c4gIABafIH/RMOU8+mzZts8yRFUKHKB1D/ 89sG/dfLWTShhJoK4omD9h4BzntQgzBviyhEsQuaAgYATg+3Ok503wd+WhEEkVub IqqXoz4Pu/2GSu2sWzNT9o+sXudUH/gyGsG+/ISVsBr1yF7WMSUMl8TLeOTJMUi6 hY/7lrBfNVFxEnKXS94sdf98dXCz1oGWQXDt9zv26zeayhKjMx41A11IQTZN5Lrd yMdyd4O4/r+9T6otii1utnDTQwYfRGiOb+UFoE7bD+blEL5pqSDLHsYcXpmnvhXE sAc3Koa33KimE6krJsFoKSZPDxXbefb/48e959VqF6/1Nh1/qxWmY6lonqHA0Rg= =2WWt -----END PGP SIGNATURE-----