Re: [PATCH 2/2] gdbserver/xtensa: fix typo in XCHAL_HAVE_LOOPS

On 04/17/2015 01:50 PM, Max Filippov wrote:
> On Fri, Apr 17, 2015 at 2:29 PM, Pedro Alves <[email protected]> wrote:
>> On 04/17/2015 02:14 AM, Max Filippov wrote:
>>> This fixes lbeg/lend/lcount registers handling through gdbserver.
>>>
>>> 2015-04-17  Max Filippov  <[email protected]>
>>> gdb/gdbserver/
>>>       * linux-xtensa-low.c (xtensa_fill_gregset,
>>>       xtensa_store_gregset): fix typo in XCHAL_HAVE_LOOPS
>>
>> I was curious on whether it might have been that XCHAL_HAVE_LOOP
>> used to exist and was later renamed ("as in, how did this ever work
> 
> It did work, only these three registers were inaccessible.

That's what I'd call "not work". :-)

(the point of that was that in case of a rename, it'd be
probably better to check both XCHAL_HAVE_LOOP/XCHAL_HAVE_LOOPS.)

>> OK with that change.
> 
> Ok. Can I check it in (I have write-after-approval access to binutils),
> or do I need to request such access to gdb separately?

Once the copyright issue is sorted out, please add yourself
to the gdb/MAINTAINERS file under Write After Approval.
(it's preapproved, just push it in and post it to the
gdb-patches@ list).

Since the fixes/patches are trivial, it's OK to push them
in before that is resolved.  Feel free to do that any time.

Thanks,
Pedro Alves