Re: problem with new vforkdone stop reply in 7.10
Pedro Alves <[email protected]>
| Newsgroups | gmane.comp.gdb.devel |
|---|---|
| Message-ID | <[email protected]> |
On 09/15/2015 04:46 PM, Don Breazeal wrote: > Thanks for taking care of this. I don't think you are missing > anything. I think I just over-simplified the VFORK_DONE packet > starting in my first implementation. The changes make sense to > me. It seems like you have this covered, but let me know if I > can help at all. Writing tests would be a tremendous help. > Absolutely, that should be report_exec_events. I missed making that > change from a previous version of the patchset that didn't use the > report_xxx_events variables. Alright, I'll split in two, and push then in. Testing showed no regressions. > I've started looking at adding some tests to plug some of the gaps in > fork/exec event testing. Currently I'm looking at a test that kills the > fork parent while stopped at a fork catchpoint. It seems like I should > add non-stop cases to foll-fork.exp and foll-vfork.exp as well. And > maybe the case where there are multiple vforks in progress at the same > time, if I can come up with something that is reliable. That would be much appreciated! Thanks, Pedro Alves