RE: Returning value from void functin in record_btrace_resume() from gdb/record-btrace.c

> -----Original Message-----
> From: [email protected] [mailto:[email protected]] On
> Behalf Of Albert Chin
> Sent: Wednesday, October 7, 2015 11:01 PM
> To: [email protected]
> Subject: Returning value from void functin in record_btrace_resume() from
> gdb/record-btrace.c

Hello Albert,

Thanks for reporting this issue.

> In record_btrace_resume() from gdb/record-btrace.c:
> static void
> record_btrace_resume (struct target_ops *ops, ptid_t ptid, int step,
>                       enum gdb_signal signal)
> {
>   struct thread_info *tp, *other;
>   enum btrace_thread_flag flag;
> 
>   ...
> 
>   /* As long as we're not replaying, just forward the request.  */
>   if (!record_btrace_is_replaying (ops) && execution_direction !=
> EXEC_REVERSE)
>     {
>       ops = ops->beneath;
>       return ops->to_resume (ops, ptid, step, signal);
>     }
> 
> I presume the return should be split into?
>       ops->to_resume (ops, ptid, step, signal);
>       return;

It should.  I'll fix it.

thanks,
Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul
Chairperson of the Supervisory Board: Tiffany Doon Silva
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928