Re: [binutils-gdb] Enable support for x86 debug registers on NetBSD.

On 05.09.2017 04:43, John Baldwin wrote:
> -/* Not all versions of FreeBSD/i386 that support the debug registers
> -   have this macro.  */
> +/* Helper macro to access debug register X.  FreeBSD/amd64 and modern
> +   versions of FreeBSD/i386 provide this macro in system headers.  Define
> +   a local version for systems that do not provide it.  */
>  #ifndef DBREG_DRX
> +#ifdef __NetBSD__
> +#define DBREG_DRX(d, x) ((d)->dr[x])
> +#else
>  #define DBREG_DRX(d, x) ((&d->dr0)[x])
>  #endif
> +#endif
>  
>  static unsigned long
>  x86bsd_dr_get (ptid_t ptid, int regnum)
> 

Do we support FreeBSD releases developed in year 2002? This macro has
point for such old systems as it keeps compat between old and new
structure layout.

"bsdphk committed on 20 Oct 2002"
https://github.com/freebsd/freebsd/commit/6c70e7ba980490dd092e728144518733eed32383

I think we are now ready to just drop it entirely. I've deliberately
decided to not include them on NetBSD.

Another place that it keeps dusting is in wine.

Regardless thanks for committing the patches!

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJZrmTOAAoJEEuzCOmwLnZsOzAP/jCO//kPriaD/tf8XQoPGvwt
PLvTpLc/K6e4D5EvX5Q6MHnuFEaFfXmJBx1DZ5boeg0HougNF1MmEJxhGWIE/+ct
jE6czgGJvMrdd1LTW7Q70jbUXu3o0AI6+Jru4hcaCZtDIcNYS4FsVVZ1jSEA/fxf
MqSdbGCiTqsyo8nKx4DMrkQQQUt4bpPhghqasLcSWm4iWI1e+EptXp108yJToLD4
rw8ZrIGjrqx9T4wIhQC6J6H8s6LzoHkK4rfHRIgt/P7HiI07HKZxFgp8SS9vovGL
25yyhoCnq13fDpcJLmC4OVc+V7WEgia+UP7TAJeDQVbQcPlIuC4BURIL8Qu/lm3m
+iMKZr8J4pMW8UBmS60ILf82DTLcyd7oHPbiH3c/uEyzjQaaA16Q0wS3w/Qjz+0B
WylcwP0PVdJ6L/4fnyPeMJTIl+lrFVw47c/IWHj1JBSazR7OFyiqd3j2P1H4Wxbe
TMLtuIWZ0rW66xZl36ZFcTwZ/mS1dXkvckfyGxn7w4mtmzd6wZkdEC6YkYKO51nJ
y6pgGa1OxuKc8G17vtlE8nJ0ivqRMcTeFSgzkJi6Cs/WMsi1JJtVQzhF2yjx5sjV
br4aMxJXXL7agN57TVZJTUQNjN+zndR7TYLAzKSm7SPbq9ZfkW12bnQjSRPuoReo
glQJb0htODy4Hx2QbFlZ
=mGlP
-----END PGP SIGNATURE-----