Re: [PATCH v2 09/28] arm64/sve: Signal frame and context structure definition
Dave Martin <[email protected]>
| Newsgroups | gmane.linux.kernel.cross-arch,gmane.comp.lib.glibc.alpha,gmane.comp.gdb.devel,gmane.comp.emulators.kvm.arm.devel,gmane.linux.ports.arm.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Sep 13, 2017 at 06:36:18AM -0700, Catalin Marinas wrote: > On Thu, Aug 31, 2017 at 06:00:41PM +0100, Dave P Martin wrote: > > +/* > > + * The SVE architecture leaves space for future expansion of the > > + * vector length beyond its initial architectural limit of 2048 bits > > + * (16 quadwords). > > + */ > > +#define SVE_VQ_BYTES 0x10 /* number of bytes per quadword */ > > + > > +#define SVE_VQ_MIN 1 > > +#define SVE_VQ_MAX 0x200 > > Just a nitpick (up to you): could you use 16 and 512 here instead of > hex? I usually associate hex numbers with some bit fields. I have no strong opinion other than a desire to make these constants typo-proof. There's no particular reason why these shouldn't be in decimal, so I can change them if you like, provided you promise to notice if I misspell 512 as 521... (git grep 131027) Cheers ---Dave