Re: RISC-V: decr_pc_after_break causing problems
Jim Wilson <[email protected]>
| Newsgroups | gmane.comp.gdb.devel |
|---|---|
| Message-ID | <CAFyWVaYH9+8hG5KkLrJtLbFYZkFw0iHctdeAupkwdpBGS4a5Kw@mail.gmail.com> |
On Wed, Jul 11, 2018 at 11:20 AM, Jim Wilson <[email protected]> wrote: > On Wed, Jul 11, 2018 at 10:46 AM, Andrew Burgess > <[email protected]> wrote: >> * Jim Wilson <[email protected]> [2018-06-25 19:54:14 -0700]: >> >>> The RISC-V port in the riscv-tdep.c file has >>> set_gdbarch_decr_pc_after_break (gdbarch, (has_compressed_isa ? 2 : 4)); Since everyone seems to agree that gdb should not be modifying pc if it is unnecessary, I went ahead and submitted the linux kernel patch side of this. https://patchwork.kernel.org/patch/10524925/ We now need a gdb change to remove the code that calls set_gdbarch_decr_pc_after_break, the has_compressed_isa local, and the now incorrect comment in riscv_has_feature. I can submit a patch for that. Jim