Re: [PATCH v2 0/2] MI: Add new command -complete
Pedro Alves <[email protected]>
| Newsgroups | gmane.comp.gdb.devel,gmane.comp.gdb.patches |
|---|---|
| Message-ID | <[email protected]> |
I'm totally not against this new command at all, but I have to say that I'd be much more thrilled if someone just spent the time to make separate CLI/MI channels work on Windows too. The channel doesn't _have_ to be a PTY. On 02/26/2019 07:49 PM, Tom Tromey wrote: >>>>>> "Jan" == Jan Vrany <[email protected]> writes: > > Jan> Are there any other GDB/MI users to comment on this? What would you > Jan> prefer? > > Given the lack of response, I think you should just say which you > prefer. If you think it would be better the "other" way, go for it. > Or if you'd rather the patches you already have, let me know. Jan, please consider the wildmatching case. E.g., when debugging GDB itself: (gdb) b push_bac<TAB> Display all 102 possibilities? (y or n) debug_names::offset_vec_tmpl<unsigned int>::push_back_reorder(unsigned long) debug_names::offset_vec_tmpl<unsigned long>::push_back_reorder(unsigned long) std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::push_back(char) ... The frontend needs to complete "b push_bac" -> "b push_back", and present the matches. But the least common denominator is not at the start of the matches strings. How will a frontend compute the LCD from the matches list alone? Please mind the "2018" copyright year in the testcase. Thanks, Pedro Alves