Re: [PATCH v2 1/3] arm64/sve: Fix missing SVE/FPSIMD endianness conversions

On Thu, Jun 13, 2019 at 11:17:27AM +0100, Will Deacon wrote:
> On Thu, Jun 13, 2019 at 11:00:34AM +0100, Dave Martin wrote:
> > On Wed, Jun 12, 2019 at 06:46:04PM +0100, Julien Grall wrote:
> > > On 12/06/2019 17:00, Dave Martin wrote:
> > > >diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h
> > > >index 7b7ac0f..072ea1e 100644
> > > >--- a/arch/arm64/include/uapi/asm/kvm.h
> > > >+++ b/arch/arm64/include/uapi/asm/kvm.h
> > > >@@ -260,6 +260,13 @@ struct kvm_vcpu_events {
> > > >  	 KVM_REG_SIZE_U256 |						\
> > > >  	 ((i) & (KVM_ARM64_SVE_MAX_SLICES - 1)))
> > > >+/*
> > > >+ * Register values for KVM_REG_ARM64_SVE_ZREG(), KVM_REG_ARM64_SVE_PREG() and
> > > >+ * KVM_REG_ARM64_SVE_FFR() and represented in memory in an endianness-
> > > 
> > > NIT: s/and represented/are represented/ I think.
> > > 
> > > >+ * invariant layout which differs from the layout used for the FPSIMD
> > > >+ * V-registers on big-endian systems: see sigcontext.h for more explanaion.
> > > 
> > > NIT: s/explanaion/explanation/
> > 
> > Dang, the first of these two is quite confusing.
> > 
> > I might send a fix for that, but I guess it's not urgent.  Thanks for
> > spotting it.
> 
> I've pushed an updated version out so hopefully no need to do anything more.

Ah, OK.  Great.

Thanks
---Dave