Re: GDB 9 TUI mode broken
Tom Tromey <[email protected]>
| Newsgroups | gmane.comp.gdb.devel,gmane.comp.gdb.patches |
|---|---|
| Message-ID | <[email protected]> |
>>>>> "Eli" == Eli Zaretskii <[email protected]> writes: Eli> Tom, where's the position update of the status line supposed to be Eli> handled? I looked at the gdb-9 branch. In tui_adjust_win_heights, it is code like this: locator->resize (1, width, 0, (second_win->origin.y + second_win->height + 1)); Eli> And btw, the meaning of the 'locator' object in tui_adjust_win_heights Eli> is unclear: to which window does it pertain, and what is the Eli> significance of this line: You and Simon discussed this down-thread. FWIW the name "locator" has been used in the source since the beginning; but I also don't particularly care for it (for a long time I could never remember the name and had to search to find it whenever I needed it). So, I would appreciate a rename in the code here as well. Also, thanks for pointing out that this is called "status" in the docs. That affects my other series to make user-specified layouts. In that series I called the window "locator" -- but I'm going to go rename it. Eli> TUI_CMD_WIN-> origin.y = locator->origin.y + 1; This is a leftover and should be removed. The resize method is the way to modify a window's size and position. This code is all different on git master. Your patch looks reasonable to me. Tom