Re: source annotation now prints source line

Bob Rossi <[email protected]>
Newsgroups gmane.comp.gdb.devel
Message-ID <[email protected]>
On Sat, Apr 04, 2020 at 07:54:24PM -0400, Bob Rossi wrote:
> When the source annotation is sent to the front end, the source line
> is now also sent to the front end console. I believe this commit
> introduced it,
>   https://github.com/bminor/binutils-gdb/commit/ec8e2b6d3051f0b4b2a8eee9917898e95046c62f
> 
> Now CGDB displays,
>     (gdb) n
>     43          int i = 3;
>     (gdb) 
> 
> Instead of,
>     (gdb) n
>     (gdb) 
> 
> CGDB is a front end, and so it has a source view to display the code to
> the user. Why did GDB decide to also print the line of code to the front
> end's console window as well? This is confusing.

The concept behind this commit seems incorrect.

The motivation for the patch isn't clearly explained in
the commit message. I believe I've given a reasonable explanation
on why this patch makes no sense for front ends.

Should I submit a patch reverting it?

Thanks,
Bob Rossi
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.