Re: source annotation now prints source line

* Andrew Burgess <[email protected]> [2020-04-14 13:17:05 +0100]:

> * Bob Rossi <[email protected]> [2020-04-14 07:23:04 -0400]:
>
> > On Sat, Apr 04, 2020 at 07:54:24PM -0400, Bob Rossi wrote:
> > > When the source annotation is sent to the front end, the source line
> > > is now also sent to the front end console. I believe this commit
> > > introduced it,
> > >   https://github.com/bminor/binutils-gdb/commit/ec8e2b6d3051f0b4b2a8eee9917898e95046c62f
> > >
> > > Now CGDB displays,
> > >     (gdb) n
> > >     43          int i = 3;
> > >     (gdb)
> > >
> > > Instead of,
> > >     (gdb) n
> > >     (gdb)
> > >
> > > CGDB is a front end, and so it has a source view to display the code to
> > > the user. Why did GDB decide to also print the line of code to the front
> > > end's console window as well? This is confusing.
> >
> > The concept behind this commit seems incorrect.
> >
> > The motivation for the patch isn't clearly explained in
> > the commit message. I believe I've given a reasonable explanation
> > on why this patch makes no sense for front ends.
> >
> > Should I submit a patch reverting it?
>
> The patch in context is discussed here:
>
>   https://sourceware.org/pipermail/gdb-patches/2019-June/158310.html
>   https://sourceware.org/pipermail/gdb-patches/2019-June/158350.html
>   https://sourceware.org/pipermail/gdb-patches/2019-June/158351.html
>   https://sourceware.org/pipermail/gdb-patches/2019-June/158352.html
>   https://sourceware.org/pipermail/gdb-patches/2019-June/158353.html
>
> I'm not sure you've convinced me yet that the idea behind the patch is
> incorrect.  Annotations should be a (deprecated) way for F/Es to parse
> GDB's output, but they shouldn't impact _what_ GDB prints.
>
> In this particular case, printing the source line actually updates
> some internal state, which impacts how later commands operate.  What
> this means is that the users session will behave differently if they
> have annotations on than when annotations are off.
>
> I guess, what I don't understand is that if a F/E wants to hide a
> particular piece of the output, why can't it just strip that from the
> output stream?  The F/E must already be removing the annotation
> markers, so all the output must be going through the F/E anyway.
>
> Further, removing this particular piece of output makes sense for this
> F/E, but is it always going to be true for all F/Es?
>
> I haven't gone back and looked at the old behaviour, maybe I'll have
> more thoughts once I've looked at that again.

For the record, here's GDB's output before the patch (8.3.1):

  ## START ##
  Temporary breakpoint 1, main () at hello.c:6
  6	  printf ("Hello World\n");
  (gdb) set annotate 0xff

  ��pre-prompt
  (gdb)
  ��prompt
  n

  ��post-prompt

  ��starting
  Hello World

  ��source /home/andrew/tmp/hello.c:7:62:beg:0x401134

  ��stopped

  ��pre-prompt
  (gdb)
  ��prompt
  ## END ##

And here's the output after the patch (9.1):

  ## START ##
  Temporary breakpoint 1, main () at hello.c:6
  6	  printf ("Hello World\n");
  (gdb) set annotate 0xff

  ��pre-prompt
  (gdb)
  ��prompt
  n

  ��post-prompt

  ��starting
  Hello World

  ��source /home/andrew/tmp/hello.c:7:62:beg:0x401134
  7	  return 0;

  ��stopped

  ��pre-prompt
  (gdb)
  ��prompt
  ## END ##

I guess I'd still suggest that the "right" thing would be to strip the
output when processing GDB's output.  But, if you strongly disagree
then you could put forward a patch for discussion.  However, I think
you'd need to do more than revert the original patch.

If you look inside source.c:print_source_lines_base then you'll see
the current source line and symtab being updated.  This is done as
part of printing the '7  ..... return 0' line.  If you'd going to stop
this being printed, then you'd need to duplicate this behaviour
somewhere else, so that the current line/symtab are updated when
annotations are on.

Thanks,
Andrew