Re: [PATCH] sim/bfin: include config/pkg.m4 in configure.ac

On 2020-08-21 3:30 a.m., Sebastian Huber wrote:
> Hello Simon,
> 
> On 20/08/2020 16:04, Simon Marchi wrote:
> 
>> On 2020-08-20 9:45 a.m., Simon Marchi wrote:
>>> On 2020-08-20 9:43 a.m., Andreas Schwab wrote:
>>>> That's because aclocal cannot find a definition of PKG_CHECK_MODULES.
>>>> You need to run autoreconf with -I ../../config.
>>> Indeed, that's what I found in the end.  Though I'll propose a patch that
>>> adds the required include to configure.ac.
>> Here's the patch:
>>
>>  From 45dce782e0a999efb892588885fc4c7f7e2e0868 Mon Sep 17 00:00:00 2001
>> From: Simon Marchi<[email protected]>
>> Date: Thu, 20 Aug 2020 09:31:49 -0400
>> Subject: [PATCH] sim/bfin: include config/pkg.m4 in configure.ac
> 
> thanks for the patch. I tried it out on Linux and it fixes the build issue.
> 
> GNU gdb (GDB) 10.0.50.20200821-git
> Copyright (C) 2020 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
> Type "show copying" and "show warranty" for details.
> This GDB was configured as "--host=x86_64-pc-linux-gnu --target=bfin-rtems5".
> Type "show configuration" for configuration details.
> For bug reporting instructions, please see:
> <https://www.gnu.org/software/gdb/bugs/>.
> Find the GDB manual and other documentation resources online at:
>     <http://www.gnu.org/software/gdb/documentation/>.
> 
> For help, type "help".
> Type "apropos word" to search for commands related to "word".
> No symbol table is loaded.  Use the "file" command.
> (gdb) tar sim
> Connected to the simulator.
> (gdb) quit
> 
> 

Ok, thanks for checking, I pushed it.

Simon