Re: [ANNOUNCEMENT] GDB 11 release branch created!

On 7/4/21 11:06 AM, Andreas Schwab wrote:
> On Jul 03 2021, Joel Brobecker wrote:
> 
>> The prerelease snapshots will be available at:
>>
>>     ftp://sourceware.org/pub/gdb/snapshots/branch/gdb.tar.xz
> 
> The tarball contains the file gdb/doc/GDBvn.texi which is a generated
> file depending on the configuration.  This breaks building with
> --with-system-readline.

Hi,

I managed to reproduce this.

The steps are:
- download (or create using src-release.sh) a snapshot
- unpack it, into say src
- cd src; find -name "*.info*" | xargs rm -f
- mkdir build; cd build ; ../src/configure --with-system-readline
- cd build; make all-gdb

For make output, see below.

This can be fixed/worked around by doing:
...
$ rm -f gdb/doc/GDBvn.texi
...
as Andreas did here (
https://build.opensuse.org/package/rdiff/home:AndreasSchwab/gdb?linkrev=base&rev=143
).

My guess is that this is a regression since:
...
commit ab954e4a53cab8c33728e6708695abc1616c90b1
Author: Bernd Edlinger <[email protected]>
Date:   Wed Nov 25 18:52:49 2020 +0100

    Fix building gdb release from tar file without makeinfo

    Add GDBvn.texi and version.subst to the release tar file,
    so the gdb.info does not need makeinfo.

    This avoids the need for makeinfo to be available.
...

Interestingly, there are previous commits related to GDBvn.texi where
the submission emails show the same problem (
https://sourceware.org/pipermail/gdb-patches/2011-January/078980.html ),
and the final conclusion of that discussion (
https://sourceware.org/pipermail/gdb-patches/2011-January/079001.html ) is:
...
So, unless anyone else objects, removing GDBvn.texi from the
distributed files is the solution.
...

Thanks,
- Tom

...
make[2]: Entering directory '/home/vries/upstream/tmp/build/gdb'
make[3]: Entering directory '/home/vries/upstream/tmp/build/gdb/doc'
(test "ln -s" = "ln -s" && \
  ln -s ../../../src/gdb/doc/all-cfg.texi gdb-cfg.texi) || \
ln ../../../src/gdb/doc/all-cfg.texi gdb-cfg.texi || \
cp ../../../src/gdb/doc/all-cfg.texi gdb-cfg.texi
makeinfo --split-size=5000000  -DHAVE_MAKEINFO_CLICK  -I
../../../src/gdb/doc/../mi -I ../../../src/gdb/doc \
        -o gdb.info ../../../src/gdb/doc/gdb.texinfo
../../../src/gdb/doc/gdb.texinfo:38160: @include: could not find rluser.texi
../../../src/gdb/doc/gdb.texinfo:38161: @include: could not find hsuser.texi
../../../src/gdb/doc/gdb.texinfo:25774: @xref reference to nonexistent
node `Command Line Editing'
../../../src/gdb/doc/gdb.texinfo:25806: @xref reference to nonexistent
node `Using History Interactively'
../../../src/gdb/doc/gdb.texinfo:25902: @xref reference to nonexistent
node `Event Designators'
../../../src/gdb/doc/gdb.texinfo:28508: @pxref reference to nonexistent
node `Command Line Editing'
../../../src/gdb/doc/gdb.texinfo:172: @menu reference to nonexistent
node `Command Line Editing'
../../../src/gdb/doc/gdb.texinfo:173: @menu reference to nonexistent
node `Using History Interactively'
make[3]: *** [Makefile:491: gdb.info] Error 1
make[3]: Leaving directory '/home/vries/upstream/tmp/build/gdb/doc'
make[2]: *** [Makefile:1973: subdir_do] Error 1
make[2]: Leaving directory '/home/vries/upstream/tmp/build/gdb'
make[1]: *** [Makefile:1639: all] Error 2
make[1]: Leaving directory '/home/vries/upstream/tmp/build/gdb'
make: *** [Makefile:10116: all-gdb] Error 2
...