[PATCH] x86: Disable 2 tests with large memory requirement
"H.J. Lu via Binutils" <[email protected]>
| Newsgroups | gmane.comp.gnu.binutils,gmane.comp.gdb.devel |
|---|---|
| Message-ID | <CAMe9rOppFL7kiYOPyApPtr6BWWqnEsfKcakFJdUMSM4qtxwj9Q@mail.gmail.com> |
On Tue, Apr 26, 2022 at 4:33 PM Alan Modra <[email protected]> wrote: > > On Tue, Apr 26, 2022 at 08:54:49AM -0700, H.J. Lu wrote: > > On Mon, Apr 25, 2022 at 8:33 PM Alan Modra <[email protected]> wrote: > > > > > > On Mon, Apr 25, 2022 at 08:20:50PM +0200, Mark Wielaard wrote: > > > > I think we should try to keep builds/checks under 10 minutes, that the > > > > > > Related to that, there are some x86_64 gas and ld tests that I find to > > > be annoying resource hogs when running multiple binutils target builds > > > in parallel. gas/testsuite/gas/i386/rept and > > > ld/testsuite/ld-x86-64/pr17618 both require over 1G of memory. > > > > > > HJ, would you please look at reducing the memory footprint of those > > > test? > > > > These tests check if large memory footprints are handed properly. > > What do you recommend? > > Delete the gas test. For the ld plt overflow test, don't use .space > in the .s file to create a huge .text section, instead use a linker > script to place sections so as to cause the address overflow. Or just > delete the ld test too. What future failure does it prevent? Someone > deleting the plt overflow checks? > > I am disabling these tests. -- H.J.
0001-x86-Disable-2-tests-with-large-memory-requirement.patch
(text/x-patch, 1.4 KB)
From 69f1317da0d9781c13dbf91a607f4bc80cfcf638 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" <[email protected]> Date: Wed, 27 Apr 2022 11:26:44 -0700 Subject: [PATCH] x86: Disable 2 tests with large memory requirement gas/ * testsuite/gas/i386/i386.exp: Disable rept. ld/ * testsuite/ld-x86-64/x86-64.exp: Disable pr17618. --- gas/testsuite/gas/i386/i386.exp | 3 ++- ld/testsuite/ld-x86-64/x86-64.exp | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/gas/testsuite/gas/i386/i386.exp b/gas/testsuite/gas/i386/i386.exp index 2c84ccc62b4..1e10277da31 100644 --- a/gas/testsuite/gas/i386/i386.exp +++ b/gas/testsuite/gas/i386/i386.exp @@ -726,7 +726,8 @@ run_list_test "string-bad" "" run_list_test "reg-bad" "" run_list_test "space1" "-al" run_list_test "xmmword" "" -run_dump_test rept +# Disabled due to large memory requirement. +# run_dump_test rept run_dump_test pr19498 run_list_test "nop-bad-1" "" run_list_test "unspec" "" diff --git a/ld/testsuite/ld-x86-64/x86-64.exp b/ld/testsuite/ld-x86-64/x86-64.exp index f337b485901..1a7d1eddc97 100644 --- a/ld/testsuite/ld-x86-64/x86-64.exp +++ b/ld/testsuite/ld-x86-64/x86-64.exp @@ -2314,8 +2314,8 @@ run_ld_link_tests [list \ ] \ ] -# Linux only tests -if { "$LD_CLASS" == "64bit" } then { +# Linux only tests. Disabled due to large memory requirement. +if { "x$LD_CLASS" == "64bit" } then { # This test needs 64-bit linker. run_dump_test "pr17618" } -- 2.35.1