RE: [builder] gdb_check_step: remove gdb.gdb/selftest.exp

Mark:

The test was failing the same way when running locally.  It was a test
issue related to checking for hardware watchpoint support on PowerPC. I
posted a patch to fix it.  Andrew Burgess merged a similar patch that
he did to fix the test with my patch and committed the fix.  The test
is now running correctly locally.  Note, I have not tested it in the
remote configuration as you mentioned.   Here is the commit for the
fix:

commit 13f72372413400410aaa94b7f0e2ff7de663fdcb
Author: Carl Love <[email protected]>
Date:   Wed Jun 22 16:14:20 2022 +0100

    gdb/testsuite: fix gdb.base/break-idempotent.exp on ppc
    
    When running the gdb.base/break-idempotent.exp test on ppc, I was
    seeing some test failures (or rather errors), that looked like
this:
    
      (gdb) watch local
      Hardware watchpoint 2: local
    
      has_hw_wp_support: Hardware watchpoint detected
      ERROR: no fileid for gcc2-power8
      ERROR: Couldn't send delete breakpoints to GDB.
      ERROR OCCURED: can't read "gdb_spawn_id": no such variable
          while executing
...

Please let me know if you see any additional issues with the test. 
Thanks.

                    Carl 


On Fri, 2022-06-10 at 21:11 +0200, Mark Wielaard wrote:
> Hi Carl,
> 
> On Fri, Jun 10, 2022 at 08:54:00AM -0700, Carl Love wrote:
> > On Fri, 2022-06-10 at 11:58 +0100, Luis Machado wrote:
> > > On 6/10/22 11:50, Mark Wielaard wrote:
> > > > On Fri, 2022-06-10 at 01:21 +0200, Mark Wielaard wrote:
> > > > > On Fri, Jun 10, 2022 at 01:09:19AM +0200, Mark Wielaard
> > > > > wrote:
> > > > > > On Thu, Jun 09, 2022 at 10:37:58AM +0100, Luis Machado
> > > > > > wrote:
> > > > > > > I always use gdb.base/break.exp as a good smoke test. If
> > > > > > > that
> > > > > > > one
> > > > > > > fails, then things
> > > > > > > are really broken.
> > > > > > > 
> > > > > > > I think gdb.base/break*.exp should make a good smoke test
> > > > > > > list.
> > > > > > > We just need to exclude
> > > > > > > gdb.base/break-interp.exp, which is problematic on some
> > > > > > > targets.
> > 
> > Trying to to understand how you are running the test.  I think you
> > are
> > running these as remote tests, i.e. machine A requests that a
> > remote
> > machine B run the test via gdbserver, correct?
> 
> Yes, but machine A and B are the same one in this case.  The tests
> are
> run three times. Once with just gdb, and then with a target-board set
> to either native-gdbserver or native-extended-gdbserver.
> 
> The buildbot log stdio should show you the exact settings.
> 
> https://builder.sourceware.org/buildbot/#/builders/76/builds/446/steps/12/logs/stdio 
> 
> make -j4 check-gdb 'TESTS= gdb.base/break-always.exp gdb.base/break-
> caller-line.exp gdb.base/break-entry.exp gdb.base/break.exp
> gdb.base/break-fun-addr.exp gdb.base/break-idempotent.exp
> gdb.base/break-include.exp gdb.base/break-inline.exp gdb.base/break-
> main-file-remove-fail.exp gdb.base/break-on-linker-gcd-function.exp
> gdb.base/breakpoint-in-ro-region.exp gdb.base/breakpoint-shadow.exp
> gdb.base/break-probes.exp gdb.gdb/unittest.exp
> gdb.server/unittest.exp ' 'RUNTESTFLAGS="--target_board=native-
> gdbserver"'
> 
> So it is the RUNTESTFLAGS="--target_board=native-gdbserver" that
> tells
> the test to run against the native-gdbserver.
> 
> Cheers,
> 
> Mark
>