Re: [builder] gdb_check_step: remove gdb.gdb/selftest.exp

Hi Carl,

On Wed, Jun 29, 2022 at 08:58:43AM -0700, Carl Love wrote:
> The test was failing the same way when running locally.  It was a test
> issue related to checking for hardware watchpoint support on PowerPC. I
> posted a patch to fix it.  Andrew Burgess merged a similar patch that
> he did to fix the test with my patch and committed the fix.  The test
> is now running correctly locally.  Note, I have not tested it in the
> remote configuration as you mentioned.   Here is the commit for the
> fix:
> 
> commit 13f72372413400410aaa94b7f0e2ff7de663fdcb
> Author: Carl Love <[email protected]>
> Date:   Wed Jun 22 16:14:20 2022 +0100
> 
>     gdb/testsuite: fix gdb.base/break-idempotent.exp on ppc
>     
>     When running the gdb.base/break-idempotent.exp test on ppc, I was
>     seeing some test failures (or rather errors), that looked like
> this:
>     
>       (gdb) watch local
>       Hardware watchpoint 2: local
>     
>       has_hw_wp_support: Hardware watchpoint detected
>       ERROR: no fileid for gcc2-power8
>       ERROR: Couldn't send delete breakpoints to GDB.
>       ERROR OCCURED: can't read "gdb_spawn_id": no such variable
>           while executing
> ...
> 
> Please let me know if you see any additional issues with the test. 

Lets add it back to the buildbot tests and see if anything breaks.

Cheers,

Mark

From a1f7675ab2fa8a4c987d0e7f1fb53de564cf9ed9 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <[email protected]>
Date: Thu, 30 Jun 2022 00:40:08 +0200
Subject: [PATCH] gdb_test_exp: Add gdb.base/break-idempotent.exp back

This should now work on all arches
---
 builder/master.cfg | 1 +
 1 file changed, 1 insertion(+)

diff --git a/builder/master.cfg b/builder/master.cfg
index 219f88d..729ec37 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -1820,6 +1820,7 @@ gdb_test_exp = ("TESTS= "
                 "gdb.base/break-entry.exp "
                 "gdb.base/break.exp "
                 "gdb.base/break-fun-addr.exp "
+                "gdb.base/break-idempotent.exp "
                 "gdb.base/break-include.exp "
                 "gdb.base/break-inline.exp "
                 "gdb.base/break-main-file-remove-fail.exp "
-- 
2.30.2