Re: Proposal: Add review tags to patch review workflow.
Simon Marchi via Gdb <[email protected]>
| Newsgroups | gmane.comp.gdb.devel |
|---|---|
| Message-ID | <[email protected]> |
On 2022-09-27 03:58, Bruno Larsen via Gdb wrote: > > On 26/09/2022 15:55, Simon Marchi wrote: >> >> On 2022-09-21 07:04, Bruno Larsen via Gdb wrote: >>> TL;DR: I want to introduce the usage of 3 new review tags to the GDB patch review workflow. They are: Reviewed-by, Approved-by and Tested-by. >> Hi Bruno, >> >> I completely agree with the proposal. I really like the fact that it >> makes communication less ambiguous. Following some process (or changing >> the process) can feel a bit heavy for long-timers, but I think it makes >> things much clearer for newcomers. >> >> Assuming we will go through with this proposal, it will need to be >> documented on the wiki so we can easily refer people to the procedure. >> Probably the ContributionChecklist page? >> >> https://sourceware.org/gdb/wiki/ContributionChecklist >> >> Will you be able to take care of this when needed (do you have write >> access to the wiki)? > > Hi Simon, > > Thanks for the reply! I don't have write access to the wiki (In fact, I just created my account on it), can you give me the necessary permissions, or do I need to ask someone else? (in case it is the latter, who?) Done. Simon