Re: Proposal: Add review tags to patch review workflow.
Pedro Alves <[email protected]>
| Newsgroups | gmane.comp.gdb.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi! On 2022-10-10 10:27 a.m., Bruno Larsen via Gdb wrote: > 1. If you have the authority to approve a patch and believe the patch > you are reviewing is ready to be merged, add the following line to your > e-mail (usually at the end): Approved-by: Your Name > <[email protected]> > > 2. If you don't have the authority to approve patches, or aren't > convinced that you know enough about the area of code to fully approve a > patch for merging, and haven't found any technical issues (i.e. > non-nitpicks) with the patch, add the following line to your e-mail: > Reviewed-by: Your Name <[email protected]> > > 3. If you aren't sure of the quality of the technical changes, but you > have tested and verified that the patch does not add any regressions, > add the following line to your e-mail: Tested-by: Your Name > <[email protected]> (Should not be a surprise since I said as much at the Cauldron, but,) FAOD, I'm for giving this a try. Pedro Alves