Re: Any concrete plans after the GDB BoF?

On 2/13/23 14:24, Tom Tromey wrote:
> Luis> It is also a burden for reviewing. It doesn't seem like the kind
> Luis> of thing people should be doing manually at this point in time.
> 
> The ability to read the code and change one's style to adapt is a
> quality signal to reviewers.  However if that goes away it probably
> won't be a huge loss.

That's fair. But should we consider the current state of today's helper tools (auto-formatters, code review tools etc) from the perspective of lowering the bar to what is required for new contributors to volunteer some work to gdb?

> 
> Luis> Yes, there is a gnu style there already, but we haven't decide if
> Luis> it is good enough or not.
> 
> IMO it definitely isn't but feel free to log your findings in the bug.
> One of these days I'll dig up the counter-examples that I dislike and do
> that myself as well.

I've used clang-format for another project, and to be honest I didn't find much I couldn't adapt to/get used to.

The worst so far seems to be the comment reflows. They don't always come out in the best way possible. But that may be due to our use of block comments.

In terms of readability, one could argue some of the C++ constructs in the code aren't that obvious either. But they're convenient, so worth the effort to get over the syntax.

> 
> Tom