Re: Any concrete plans after the GDB BoF?

Mark Wielaard <[email protected]>
Newsgroups gmane.comp.gdb.devel
Message-ID <[email protected]>
Hi Luis,

On Mon, 2023-02-13 at 12:52 +0000, Luis Machado wrote:
> I suppose that's the point of introducing auto-formatters. If some incorrect formatting is
> pushed alongside some code, it is not a big deal. But having to manually chase some format and fix it by hand (as we do now)
> before it can go in is potentially worse.
> 
> It is also a burden for reviewing. It doesn't seem like the kind of thing people should be doing manually at
> this point in time.

Note that builder.sourceware.org can help with that. If you push a
patch to a try builder then the gdb-try-fedora-x86_64 builder will run
python black over it (and fail and put a format diff in the output log
if it doesn't match):
https://sourceware.org/git/?p=builder.git;a=blob;f=builder/master.cfg;hb=HEAD#l2735

I am hoping we can automate that with patchwork so that patches will
get a fail marker if they don't pass the format checker.

Cheers,

Mark
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.