RE: Shadow stack backtrace command name
"Schimpe, Christina via Gdb" <[email protected]>
| Newsgroups | gmane.comp.gdb.devel |
|---|---|
| Message-ID | <SN7PR11MB7638CC69F1F2D3CAEB731A4FF996A@SN7PR11MB7638.namprd11.prod.outlook.com> |
Thanks a lot for you review. Please see my feedback to your comments below. > My first thought about this output is that I don't think most users are interested in > what goes on below the main function. I think it would be nice to suppress that > output (I personally would like that to be the default, but as long as its an option > I'm happy). For the normal bt command there are the options -past-main and -past-entry. We could consider adding them to the new command for shadow stack bt as well. However, for the shadow-stack it's a bit different as the stack size depends on the enablement of shstk. > As for names, I don't see a need for starting with "info". In my opinion, just calling > it "shadow-stack backtrace" is fine. Users could then set their own abbreviations, > like shstk or cet if they like. One reason for me to have the "info" is to make the command easier to find. If the user would type "help info" the command would be listed (among others). Christina Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928