Re: gdbserver seems to have grown a dependency on libiconv

On Tue, Jul 23, 2024 at 1:43 PM Chris Packham <[email protected]> wrote:
>
> Hi,
>
> I'm just looking at adding gdb 15 to crosstool-ng. One configuration
> that's having problems is xtensa-fsf-linux-uclibc.
>
> [ERROR]    configure: error: could not find libiconv (required for
> host xtensa-fsf-linux-uclibc)[ERROR]    make[2]: *** [Makefile:10924:
> configure-gdbserver] Error 1
> [ERROR]    make[2]: *** Waiting for unfinished jobs....
>
> I don't think it's anything to do with the specific architecture but
> it just happens this configuration doesn't end up building libiconv as
> a dependency for any other part of the toolchain.
>
> Is libiconv actually a requirement for gdbserver or is this something
> that has leaked through now that gdb and gdbserver share a lot of
> infrastructure?

Answering my own question. Commit 07b3255c3ba ("Filter invalid
encodings from Linux thread names") started using iconv in gdbserver
and commit da48217f315 ("gdbserver/linux: probe for libiconv in
configure") added the configure check. So this appears completely
intentional. I'll add something to crosstool-ng to make libiconv a
dependency for gdbserver.

>
> Thanks,
> Chris