Re: automated coding style tool

Tom Tromey <[email protected]>
Newsgroups gmane.comp.gdb.devel
Message-ID <[email protected]>
Simon> If we don't like what the tool outputs, we can argue over than
Simon> and change the tool.

Yeah - but that's where we're already at.  Like, I ran clang-format on
gdb and read the diffs and found a bunch of things I didn't like.  IIRC
the main offenders were bin-packing.  I imagine Pedro did this too,
since he's made similar comments in the past.

I at least CCd myself on upstream bugs against the tool.  I commented
on some, maybe filed some too (don't remember).

I'm not super interested in hacking on clang-format, but the tool is
there and all the information for someone who is.

Simon> Also, if are missing some features to get the output we want, nobody is
Simon> going to magically implement them for us.  And if we don't use the tool,
Simon> there's no motivation for us either to go implement the changes.  I
Simon> think that the only way to get the ball rolling is to start using the
Simon> tool, even if the output is not ideal, and then if there's something
Simon> really annoying, one of us *might* have the motivation to go improve the
Simon> tool.

I'm in favor of using a tool but my view is that it has to meet some
minimal standard of usefulness.  I just think clang-format does not do
this.

Tom
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.