RE: [PATCH 7/8] Windows gdb: Implement XState (Intel AVX) support

Hi Hannes, 

Thank you for working on this.
It appears that this patch uses the same commit message header as patch #8. Is it
intentional that these are separate commits?

In any case, IMO, commit messages should not have identical headers. Also, this
patch seems big enough for a commit message which is not header only. :)

Do any AVX-* specific tests pass on Windows now? If so, it would be helpful to
mention that in the commit message as well.
I have not looked at the code yet, but I have one additional comment regarding
the NEWS entry.

> -----Original Message-----
> From: Hannes Domani <[email protected]>
> Sent: Sonntag, 12. Juli 2026 13:32
> To: [email protected]
> Subject: [PATCH 7/8] Windows gdb: Implement XState (Intel AVX) support
> 
> ---
>  gdb/NEWS              |   2 +
>  gdb/x86-windows-nat.c | 112
> ++++++++++++++++++++++++++++++++++++++++--
>  2 files changed, 111 insertions(+), 3 deletions(-)
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index ec9b5a33787..759c544d3b6 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -116,6 +116,8 @@
>    intent to remove it in a future release.
>    The s390 64-bit target (s390x-*) remains supported.
> 
> +* Support for Intel AVX variables on Windows.

What do you mean with variables? I think it could be helpful if you are
a bit more specific here. For linux there are several examples in the NEWS file,
for instance:

* Support for Intel AVX-512 registers on GNU/Linux.
  Support displaying and modifying Intel AVX-512 registers
  $zmm0 - $zmm31 and $k0 - $k7 on GNU/Linux.

Have you also considered to add some documentation in gdb.texinfo ? 

Regards,
Christina