[PATCH 1/3] gdb/testsuite: missing ';' in check-all-boards rule

Andrew Burgess <[email protected]>
Newsgroups gmane.comp.gdb.patches
Message-ID <93af307236959d9b9eb02cee73ca902028edc942.1784373976.git.aburgess@redhat.com>
The check-all-boards makefile rule was missing a semicolon.  As a
result we would pass "result=0" through to the make-check-all.sh
script.

This 'result=0' would end up inside the TESTS="..." string which was
passed to the 'make check-...' command.  As 'result=0' doesn't match
any of GDB's .exp files the 'result=0' would then be ignored.

Back in the Makefile, due to the missing semicolon, as the
'result=...'  line had become an extra argument to make-check-all.sh,
we were no longer capturing the exit status of the make-check-all.sh
script.  This means that when the 'check-all-boards' rule completed we
actually exited with the exit status of the last command rather than
with the exit status of the make-check-all.sh script.

Fix this by adding in the missing semicolon.

There should be no changes in what is tested after this commit.
---
 gdb/testsuite/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
index f103d7ddd65..44c710f8de9 100644
--- a/gdb/testsuite/Makefile.in
+++ b/gdb/testsuite/Makefile.in
@@ -386,7 +386,7 @@ check-all-boards: all $(abs_builddir)/site.exp
 	${abs_srcdir}/make-check-all.sh --keep-results \
 		--host-user "$(GDB_HOST_USERNAME)" \
 		--target-user "$(GDB_TARGET_USERNAME)" \
-		"$(TESTS)" \
+		"$(TESTS)"; \
 	result=$$?; \
 	if test -d check-all; then \
 	  $(SHELL) $(srcdir)/../../contrib/dg-extract-results.sh \
-- 
2.25.4
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.