RE: [PATCH 1/1] gdb: set the cache information in 'get_prev_frame_maybe_check_cycle'

"Rohr, Stephan" <[email protected]> writes:

> Hi Andrew,
>
> thanks for getting back with that.  This was also my first approach
> to fix the issue.  The only limitation I see is that we have a duplicate
> entry into the frame_list when we setup the return value.  When the
> dtor of prev_frame is called, it is removed again.   I see this the only
> side effect of the patch.

Sorry about that, I guess I lost track of the original proposal
somewhere along the way.

I've gone ahead and pushed this patch for now.  I ran into this issue
again with another a second series that I'm working on, so I'd like to
see this fix landed, and it looks like we're both OK with this approach.

I agree there are some minor costs, but I don't see them as significant,
and anything else will also have some cost associated anyway, so I don't
think this is obviously that much worse than anything else.

>
> I'm personally fine with the proposed change as this is a minimal fix
> for the bug.  I agree that a perfect fix would defer the frame_info_ptr
> creation until the frame-id is computed, but I think this is out of
> scope for this patch.

Agreed.  I have this down as something to look at in the future.  I have
another series in progress that touches frame related stuff, so I need
to see how that will go first, but after that I might revisit this.

Thanks,
Andrew