Re: [PATCH 04/16] gdb: convert address_class_type_flags to address_class_dwarf_to_id

>>>>> Tankut Baris Aktemur <[email protected]> writes:

> The gdbarch method 'address_class_type_flags' is used for letting an
> architecture translate the DW_AT_address_class attribute to an address
> class id.  Make this clear by refactoring the method to return an id,
> instead of a whole type instance flags value.  There is hardcoding of
> "<< 4" left in dwarf/read.c.  This will go away in a future patch.

Thank you.

>  Function(
> -    type="type_instance_flags",
> -    name="address_class_type_flags",
> +    type="unsigned int",
> +    name="address_class_dwarf_to_id",
>      params=[("int", "byte_size"), ("int", "dwarf2_addr_class")],
>      predicate=True,
>  )

Would you mind adding a 'comment' field here?

thanks,
Tom