Re: [PATCH v1 10/10] gdb/linux: add helpers to read AT_HWCAP3 and AT_HWCAP4

Luis <[email protected]> Tue, 21 Jul 2026 22:58:44 +0100
Newsgroups gmane.comp.gdb.patches
Message-ID <[email protected]>
On 09/07/2026 07:44, Thiago Jung Bauermann wrote:
> Matthieu Longo <[email protected]> writes:
> 
>> Add linux_get_hwcap3 and linux_get_hwcap4 helpers to GDB and gdbserver,
>> mirroring the existing linux_get_hwcap and linux_get_hwcap2 interfaces.
>>
>> The new helpers retrieve the AT_HWCAP3 and AT_HWCAP4 auxiliary vector
>> entry either from explicitly supplied auxv data or from the current
>> inferior.
>>
>> This prepares for future features that depend on HWCAP3 and HWCAP4
>> capability bits.
>> ---
>>   gdb/linux-tdep.c       | 38 ++++++++++++++++++++++++++++++++++++++
>>   gdb/linux-tdep.h       | 22 ++++++++++++++++++++++
>>   gdbserver/linux-low.cc | 28 ++++++++++++++++++++++++++++
>>   gdbserver/linux-low.h  |  8 ++++++++
>>   4 files changed, 96 insertions(+)
> 
> Reviewed-by: Thiago Jung Bauermann <[email protected]>
> 
> Like in the previous patch, there's nothing in this patch series that
> uses these helpers, so IMHO (other maintainers may disagree) it makes
> more sense if this patch is committed together with a patch that makes
> use of them.
> 

Agreed. Or should be its own patch instead of a part of this series.