Re: [PATCH] GDB: aarch64: Fix inferior function call if GCS is present but disabled

Tom Tromey <[email protected]> writes:

>>>>>> Aktemur, Baris <[email protected]> writes:
>
>>> +  gdbarch_get_shadow_stack_pointer (gdbarch, regcache, gcs_is_enabled);
>
>> Some analyzer tools may flag this because the return value is not being used.
>> Maybe put a `(void)` in front to indicate the return value is being ignored
>> deliberately.
>
> FWIW gdb does not normally do this unless the function is specially
> marked.

I found some places in GDB where we do this even though the called
function isn't specially marked (e.g., calls to record_stop in
gdb/record.c, and call to PyGILState_Ensure in gdb/python/python.c)
so ahead with the `(void)`.

I can push a patch removing it if anyone wants.

-- 
Thiago
(he/him)