Re: [PATCH v1 08/10] gdb/linux-tdep: migrate parse_smaps_data to file_reader_t

Matthieu Longo <[email protected]> writes:

> On 09/07/2026 07:41, Thiago Jung Bauermann wrote:
>> Matthieu Longo <[email protected]> writes:
>> 
>> Suggestion: mention in the commit log that since the previous commit,
>> the old variant of parse_smaps_data is unused.
>> 
> What about :
>
> gdb/linux-tdep: remove legacy parse_smaps_data overload
>
>     Now that all callers use the file_reader_t overload of parse_smaps_data,
>     the legacy interface taking a raw buffer and filename separately is no
>     longer needed.
>
>     Fold its implementation into the file_reader_t version and remove the
>     obsolete wrapper.  This also simplifies the implementation by using the
>     file_reader_t accessors directly.

Looks good to me, thanks!

-- 
Thiago
(he/him)