Re: [PATCH v3 1/4] Add gdbpy_borrowed_ref

Yury Khrustalev <[email protected]> Fri, 24 Jul 2026 13:02:23 +0100
Newsgroups gmane.comp.gdb.patches
Message-ID <[email protected]>
Hi Tom and Matthieu,

On Wed, Jun 03, 2026 at 12:19:37PM -0600, Tom Tromey wrote:
> >>>>> "Matthieu" == Matthieu Longo <[email protected]> writes:
> 
> >> This adds new gdbpy_opt_borrowed_ref and gdbpy_borrowed_ref classes.
> >> These classes are primarily for code "documentation" purposes -- it
> >> makes it clear to the reader that a given reference is borrowed.
> >> However, they also add a tiny bit of safety, in that conversion to
> >> gdbpy_ref<> will either be rejected (by the "opt" class) or acquire a
> >> new reference.
> 
> Matthieu> Any idea when this patch could land on master ?
> 
> It's hard to say.
> 
> For ordinary-ish patches, I tend to wait a couple of weeks and then just
> check them in if they haven't been commented on.
> 
> For something like this, though, I'd normally wait and/or ping it until
> there's some review; the difference being that a big change to how new
> Python code should be written ought to have some buy-in.
> 
> I suppose I could land this particular one sooner.  That's a little
> weird since it's not actually used by anything.  OTOH it unblocks stuff
> you're doing.

I think this has been in review for a while. If there is nothing that
needs to be fixed in this patch, could we go ahead? There is a lot of
other work that is blocked and that we'd like to progress.

Thanks,
Yury