Re: [PATCH v3 5/5] [PATCH 5/5] gdb/testsuite: Add FEAT_S1POE testcases

<[email protected]> writes:

> From: Srinath Parvathaneni <[email protected]>
>
> Add testcases for POR_EL0 register access, SIGSEGV diagnostics, fix-and-continue
> support (updating $por_el0 after SIGSEGV and continuing with signal 0), and core
> file support.
> ---
>  gdb/testsuite/gdb.arch/aarch64-poe-core.exp   | 101 ++++++++++++++++++
>  gdb/testsuite/gdb.arch/aarch64-poe-sigsegv.   |   0
>  gdb/testsuite/gdb.arch/aarch64-poe-sigsegv.c  |  52 +++++++++
>  .../gdb.arch/aarch64-poe-sigsegv.exp          |  58 ++++++++++
>  gdb/testsuite/gdb.arch/aarch64-poe.c          |  29 +++++
>  gdb/testsuite/gdb.arch/aarch64-poe.exp        |  46 ++++++++
>  gdb/testsuite/lib/gdb.exp                     |  55 ++++++++++
>  7 files changed, 341 insertions(+)
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-poe-core.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-poe-sigsegv.
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-poe-sigsegv.c
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-poe-sigsegv.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-poe.c
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-poe.exp

I don't have anything to add to Luis' comments, except to say that the
tests now pass in my testing. Thanks for making the changes!

PS: I don't have comments on patches 2-4.

-- 
Thiago
(he/him)