Re: [PATCH] gdb/testsuite: replace hipcc with amdclang++ as the HIP compiler

Pedro Alves <[email protected]> Fri, 31 Jul 2026 11:28:15 +0100
Newsgroups gmane.comp.gdb.patches
Message-ID <[email protected]>
Hi!

On 2026-07-15 10:45, Sarang Patrange wrote:
> +	# amdclang++ requires explicit --offload-arch.  Explicitly
> +	# pass one --offload-arch for each available device.  But
> +	# don't do it if the testcase explicitly used --offload-arch.
> +	if {[lsearch -exact $options hip_no_offload_arch] == -1

This hip_no_offload_arch check shouldn't be in this patch.  That option won't exist until some later
yet-sent-to-gdb-patches patch adds it.  Noticed because I'm working on preparing said patch.  :-)

> +	    && [lsearch -regexp $options "--offload-arch="] == -1} {
> +	    foreach gpu_target [hcc_amdgpu_targets] {
> +		lappend new_options "early_flags=--offload-arch=$gpu_target"