Re: [PATCH v1 4/6] gdb/linux-tdep: migrate linux_info_proc to file_reader_t

Matthieu Longo <[email protected]> writes:

> The patch migrates the code of linux_info_proc to use file_reader_t to
> read the procfs files.
> The availability of array_views allows to also simplify the logic in
> several places, where null-terminating characters are replaced by spaces,
> or where the file content is iterated line by line.
> In the last case, a new helper function, extract_string_view_from_buffer,
> encapsulates the logic for such iterations where string are separated by
> tokens.
> ---
>  gdb/linux-tdep.c | 135 +++++++++++++++++++++++++++++------------------
>  1 file changed, 84 insertions(+), 51 deletions(-)

Thank you for addressing the review comments.

Reviewed-by: Thiago Jung Bauermann <[email protected]>

-- 
Thiago
(he/him)