Re: [PATCH] Remove redundant check from check_types_equal

On 8/5/26 9:37 PM, Tom Tromey wrote:
> check_types_equal compares both is_nottext and instance_flags, but the
> latter includes the former, so the redundant check can be removed.

LGTM.

Approved-By: Tom de Vries <[email protected]>

Thanks,
- Tom

> ---
>   gdb/gdbtypes.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
> index f5c0177bff2..4b6c01910f4 100644
> --- a/gdb/gdbtypes.c
> +++ b/gdb/gdbtypes.c
> @@ -4092,7 +4092,6 @@ check_types_equal (struct type *type1, struct type *type2,
>         || type1->endianity_is_not_default () != type2->endianity_is_not_default ()
>         || type1->has_varargs () != type2->has_varargs ()
>         || type1->is_vector () != type2->is_vector ()
> -      || type1->is_nottext () != type2->is_nottext ()
>         || type1->instance_flags () != type2->instance_flags ()
>         || type1->num_fields () != type2->num_fields ())
>       return false;
> 
> base-commit: b7da195b94b423e5cfd27a14c636ffe9f7380cdd