Re: [PATCH 1/2] Don't use F_SETFL in gdbreplay

On 7/17/26 1:07 PM, Tom Tromey wrote:
> There's no need to call fcntl with F_SETFL in gdbreplay, as gdbreplay
> does not use or need SIGIO.
> ---
>  gdbserver/gdbreplay.cc | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/gdbserver/gdbreplay.cc b/gdbserver/gdbreplay.cc
> index 4426dc316ec..ba03bf64b67 100644
> --- a/gdbserver/gdbreplay.cc
> +++ b/gdbserver/gdbreplay.cc
> @@ -255,9 +255,6 @@ remote_open (const char *name)
>  #endif
>      }
>  
> -#if defined(F_SETFL) && defined (FASYNC)
> -  fcntl (remote_desc_in, F_SETFL, FASYNC);
> -#endif
>    remote_desc_out = remote_desc_in;


LGTM, but also it looks like you could drop:

#if HAVE_FCNTL_H
#include <fcntl.h>
#endif

Approved-By: Simon Marchi <[email protected]>

Simon