Re: [PATCH 1/2] gdb: fix crash when pretty printing anonymous struct with base class
Tom Tromey <[email protected]>
| Newsgroups | gmane.comp.gdb.patches |
|---|---|
| Message-ID | <[email protected]> |
>>>>> "Simon" == Simon Marchi <[email protected]> writes: Simon> As I was reviewing another patch, I was wondering if we allowed Simon type->name() to be nullptr. The answer is yes, but there are some spots Simon> that don't check for nullptr, when they should. Thanks for looking at this. I sometimes wonder if this is something we ought to fix, like reject nullptr here. But shrug. Simon> - gdb_puts (type->name (), stream); Simon> + gdb_puts (type->safe_name (), stream); It would be nice here if the <...> form were in metadata style. Tom